Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable iOS VPN survey #42

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Disable iOS VPN survey #42

merged 1 commit into from
Jan 29, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Jan 29, 2024

Task: https://app.asana.com/0/0/1206470564621802/f

This PR removes the VPN iOS survey added in #40.

To test, make sure that the modified file matches this one except with a higher version number

@samsymons samsymons requested a review from brindy January 29, 2024 21:43
Copy link

Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - added a breakpoint in the request handler and can see the matching JSON

@samsymons samsymons merged commit fdf6d2c into main Jan 29, 2024
2 checks passed
@samsymons samsymons deleted the sam/disable-vpn-survey branch January 29, 2024 21:50
samsymons added a commit that referenced this pull request Feb 5, 2024
Task: https://app.asana.com/0/0/1206470564621802/f

This PR re-enables the survey that was disabled in #42 due to issues with the iOS app loading URLs correctly.

This survey is identical to the one originally added in #40, except with the latest RMF version number and now targeting 7.106.0.4 as its minimum, which went live last week.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants