Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS survey June 2024 #66

Merged
merged 3 commits into from
Jun 5, 2024
Merged

iOS survey June 2024 #66

merged 3 commits into from
Jun 5, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Jun 5, 2024

Task: https://app.asana.com/0/1193060753475688/1207490407726840/f

This PR enables the monthly survey for iOS app users.

Testing instructions:

Note that this RMF change uses the old survey action format, meaning it should show no messages on version 7.122.0 and above. To test this, you will need to test on 7.120 or below (7.121.0 was never released, so ignore that).

  1. Update RemoteMessageRequest to include the sample URL attached in the comments below
  2. Update shouldProcessConfig to always return true
  3. Now we need to test that the install date range is working. We have no method in the Debug menu for overriding this so for now you'll need to use a local copy of BSK and search for the line case let matchingAttribute as DaysSinceInstalledMatchingAttribute
  4. Underneath the line mentioned above, you can override daysSinceInstall value to check the range. Try it with 0, 5, and 10, and expect that the message only appears for the 5 case
  5. Finally, set the value back to one that matches the range, and check that opening the link correctly opens the survey

Copy link

github-actions bot commented Jun 5, 2024

@samsymons samsymons requested a review from amddg44 June 5, 2024 03:16
@samsymons samsymons merged commit c0398f5 into main Jun 5, 2024
1 check passed
@samsymons samsymons deleted the sam/ios-survey-june-2024 branch June 5, 2024 04:22
samsymons added a commit that referenced this pull request Jun 17, 2024
# By Cristian Monforte (2) and Sam Symons (1)
# Via GitHub
* main:
  Release winner message PPro - AppTP - June (#67)
  iOS survey June 2024 (#66)
  PPro Promo June (#65)

# Conflicts:
#	live/ios-config/ios-config.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants