-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Privacy Pro exit survey #73
Conversation
Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/pre/ios-config.json |
"id": 3, | ||
"attributes": { | ||
"interactedWithMessage": { | ||
"value": [ | ||
"ios_privacy_pro_exit_survey_1" | ||
] | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to hide the New Subscriber survey from users who had an Exit survey, so we'll use this in exclusionRules
on the New Subscriber survey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Everything behaved exactly as expected 👏
Task: https://app.asana.com/0/1207619243206445/1207636661001863/f
This PR adds the Privacy Pro exit survey.
It is set up to hide the New Subscriber survey from users who have interacted with the Exit survey, using the
exclusionRules
feature.Testing steps:
RemoteMessagingClient.swift
around lines 186-197 to forceprivacyProIsExpiring
to true even if your account is active