Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Privacy Pro exit survey #73

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Jun 22, 2024

Task: https://app.asana.com/0/1207619243206445/1207636661001863/f

This PR adds the Privacy Pro exit survey.

It is set up to hide the New Subscriber survey from users who have interacted with the Exit survey, using the exclusionRules feature.

Testing steps:

  1. First, set up the app to use this RMF manifest, and check that you get no messages when signed out of Privacy Pro
  2. Sign into an active account that has been in use for 14+ days and check that you get the New Subscriber survey - do not interact with it though, since we later want to check that it is hidden when you interact with the Exit survey
  3. Override your account to simulate it being in the cancelled state, and check that you get the Exit survey instead - to do this, you can modify RemoteMessagingClient.swift around lines 186-197 to force privacyProIsExpiring to true even if your account is active
  4. Open or dismiss the Exit survey, and then check that you do not get the New Subscriber survey the next time RMF refreshes

@samsymons samsymons requested a review from a team as a code owner June 22, 2024 00:39
@samsymons samsymons requested review from THISISDINOSAUR and removed request for a team June 22, 2024 00:39
Copy link

@samsymons samsymons requested review from amddg44 and removed request for THISISDINOSAUR June 22, 2024 00:41
# By Cristian Monforte (1) and Sam Symons (1)
# Via GitHub
* main:
  iOS 14 deprecation warning (#74)
  PPro Android Onboarding promo: increase daysSinceInstalled filter (#75)

# Conflicts:
#	live/ios-config/ios-config.json
Comment on lines +103 to +110
"id": 3,
"attributes": {
"interactedWithMessage": {
"value": [
"ios_privacy_pro_exit_survey_1"
]
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to hide the New Subscriber survey from users who had an Exit survey, so we'll use this in exclusionRules on the New Subscriber survey.

Copy link
Collaborator

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Everything behaved exactly as expected 👏

@samsymons samsymons merged commit 6e49028 into main Jun 28, 2024
1 check passed
@samsymons samsymons deleted the sam/ios-privacy-pro-cancellation-survey branch June 30, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants