iOS 14 deprecation warning #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just for testing since Xcode 15 doesn’t support the iOS 14 SDK. We’ll need to download an older Xcode to test this, but for now I’ll try it against 15.
This is to avoid RMF layout issues with older iOS versions, that were fixed with this release.
samsymons
requested review from
federicocappelli and
amddg44
and removed request for
a team and
federicocappelli
|
Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/pre/ios-config.json |
samsymons
commented
Jun 24, 2024
* main: PPro Android Onboarding promo: increase daysSinceInstalled filter (#75)
This message should not display by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://app.asana.com/0/1207619243206445/1207650299373621/f
This PR adds the deprecation warning for iOS 14 users.
Testing steps:
Xcode 15 does not support the iOS 14 SDK. If you'd like to test with Xcode 15, please override the OS version being passed to RMF locally before testing.