Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Privacy Pro surveys to macOS #90

Merged
merged 5 commits into from
Aug 18, 2024
Merged

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Aug 2, 2024

Task: https://app.asana.com/0/1207619243206445/1208041703530761/f

This PR adds the Privacy Pro surveys to the macOS app.

How to test the subscriber survey:

  1. Update the client to use the staging URL below
  2. Sign into a Privacy Pro account, and, if necessary, hardcode the privacyProDaysSinceSubscribed initializer value in RemoteMessagingConfigMatcherProvider to be 14 or above
  3. Update the shouldProcessConfig func in BSK to always return true, for testing multiple cases
  4. Test that when you relaunch the app, the subscriber survey appears
  5. Now hardcode the privacyProDaysSinceSubscribed value to be below 14
  6. Relaunch the app and verify that the survey is gone

How to test the exit survey:

  1. Now we need to test an expiring account; update RemoteMessagingConfigMatcherProvider line ~94 to set isPrivacyProSubscriptionExpiring to true and all other booleans to false
  2. Relaunch the app and verify that the exit survey shows up

CleanShot 2024-08-12 at 21 06 12@2x
CleanShot 2024-08-12 at 20 51 06@2x

Copy link

github-actions bot commented Aug 2, 2024

* main:
  iOS survey August 2024 (#95)
  Enable ppro promo d1-2 (#93)
  Remove the iOS 14 deprecation message (#94)
  New Privacy pro promo for installs between 1 and 2 days (#92)
  iOS Privacy Pro survey update (#91)
@samsymons samsymons changed the title [Draft] Add Privacy Pro surveys to macOS Add Privacy Pro surveys to macOS Aug 13, 2024
Copy link

@jaceklyp jaceklyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! gj :)

@samsymons samsymons merged commit 8745b27 into main Aug 18, 2024
1 check passed
@samsymons samsymons deleted the sam/macos-privacy-pro-surveys branch August 18, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants