Update autoconsent #101
Merged
Update autoconsent #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdzwinel
reviewed
Sep 2, 2024
| @@ -186,14 +186,15 @@ class CMPCollector extends BaseCollector { | |||
| this.receivedMsgs.push(msg); | |||
| switch (msg.type) { | |||
| case 'init': { | |||
| /** @type {AutoconsentConfig} */ | |||
There was a problem hiding this comment.
TIL about <Partial>, but doesn't it mean that we DON'T have to include isMainWorld: false below? Or is the default true?
There was a problem hiding this comment.
Yep, you are right, it would work without it, but I just wanted to make it explicit.
package.json
Outdated
| @@ -7,7 +7,7 @@ | |||
| "main": "main.js", | |||
| "scripts": { | |||
| "crawl": "node ./cli/crawl-cli", | |||
| "test": "npm run lint && tsc && npm run unit", | |||
There was a problem hiding this comment.
hm, doesn't this remove typechecking? I think we want typechecking. Or is this run somehow via lint now?
There was a problem hiding this comment.
Hm, I was sure typescript-eslint did typecheking, but apparently it needs another config. I tried to enable it, but got a bunch of new errors (our code is messy), so I added tsc back here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After bumping autoconsent version,
tscstarted giving weird lint errors inside the autoconsent folder. Excluding paths didn't work, so I had to change the way we lint too