Add FB.__buffer.calls support to fb-sdk shim #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzar
force-pushed
the
expand7-fix-tiktok-fb-login
branch
from
a4a2116
to
126afb1
Compare
It turns out that some websites create a window.FB.__buffers.calls array listing the FB API calls to make, before loading the fb.sdk-js script. I couldn't see where that was documented, but let's add rough support for that flow to try and unbreak those websites.
kzar
force-pushed
the
expand7-fix-tiktok-fb-login
branch
from
126afb1
to
8f2ed29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that some websites create a window.FB.__buffers.calls
array listing the FB API calls to make, before loading the fb.sdk-js
script. I couldn't see where that was documented, but let's add rough
support for that flow to try and unbreak those websites.