Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 저버전 기기에서 상단 padding이 적용되는 문제 #671

Merged
merged 1 commit into from
Nov 19, 2023
Merged

fix: 저버전 기기에서 상단 padding이 적용되는 문제 #671

merged 1 commit into from
Nov 19, 2023

Conversation

limsaehyun
Copy link
Member

Overview (Required)

  • 안드로이드 저버전에서 기원되는 기본 theme로 인해 상단 패딩이 적용되는 문제
  • 10 >= API < 21 Holo_Theme or Theme.AppCompat
    해당 조건에서 적용되는 Holo_Theme or Theme_AppCompat이 android 내 systemPadding과 관련이 있는 것으로 보입니다.

@limsaehyun limsaehyun added the bug 버그 label Oct 22, 2023
@limsaehyun limsaehyun self-assigned this Oct 22, 2023
EvergreenTree97
EvergreenTree97 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@EvergreenTree97 EvergreenTree97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@riflockle7 riflockle7 merged commit 352063c into develop Nov 19, 2023
2 checks passed
@riflockle7 riflockle7 deleted the fix/low-version-top-padding branch November 19, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvergreenTree97 EvergreenTree97 EvergreenTree97 approved these changes

@riflockle7 riflockle7 riflockle7 approved these changes

Assignees

@limsaehyun limsaehyun

Labels
bug 버그
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@limsaehyun @riflockle7 @EvergreenTree97