Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CREDITS.md #69

Merged
merged 9 commits into from
Jul 2, 2019
Merged

Add CREDITS.md #69

merged 9 commits into from
Jul 2, 2019

Conversation

duckinator
Copy link
Owner

Alternative to #64.

@duckinator
Copy link
Owner Author

@nbraud I like your idea in #64, but:

  1. I think I'd like something a simpler in terms of formatting.
  2. I'm considering including software/libraries/services we rely on.

This is what it looks like: https://github.com/duckinator/emanate/blob/c8e2fde/CREDITS.md

What're your thoughts?

@duckinator duckinator mentioned this pull request Jul 2, 2019
Closed
nbraud
nbraud requested changes Jul 2, 2019
View reviewed changes
Copy link
Collaborator

@nbraud nbraud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot better than my original proposal ❤️

I left a bunch of suggestions, mostly crediting some stuff you missed?

CREDITS.md Show resolved Hide resolved
CREDITS.md Outdated Show resolved Hide resolved
CREDITS.md Outdated Show resolved Hide resolved
CREDITS.md Show resolved Hide resolved
CREDITS.md Outdated Show resolved Hide resolved
CREDITS.md Outdated Show resolved Hide resolved
duckinator and others added 7 commits July 1, 2019 22:30
@duckinator @nbraud
Update CREDITS.md
862d7b7 
Co-Authored-By: Nicolas Braud-Santoni <[email protected]>
@duckinator @nbraud
Update CREDITS.md
c8734a6 
Co-Authored-By: Nicolas Braud-Santoni <[email protected]>
@duckinator @nbraud
Update CREDITS.md
a2a03a9 
Co-Authored-By: Nicolas Braud-Santoni <[email protected]>
@duckinator @nbraud
Update CREDITS.md
11f4896 
Co-Authored-By: Nicolas Braud-Santoni <[email protected]>
@duckinator @nbraud
Update CREDITS.md
a11c2fc 
Co-Authored-By: Nicolas Braud-Santoni <[email protected]>
@duckinator @nbraud
Update CREDITS.md
74d9882 
Co-Authored-By: Nicolas Braud-Santoni <[email protected]>
@duckinator
Update CREDITS.md
9190634
nbraud
nbraud reviewed Jul 2, 2019
View reviewed changes
CREDITS.md Outdated Show resolved Hide resolved
@duckinator @nbraud
Update CREDITS.md
c98f813 
Co-Authored-By: Nicolas Braud-Santoni <[email protected]>
@nbraud
Copy link
Collaborator

nbraud commented Jul 2, 2019

bors r+

bors bot added a commit that referenced this pull request Jul 2, 2019
@bors @duckinator
Merge #69
ea67442 
69: Add CREDITS.md r=nbraud a=duckinator

Alternative to #64.

Co-authored-by: Ellen Marie Dash <[email protected]>
Co-authored-by: Ellen Marie Dash <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jul 2, 2019

Build succeeded

  • Windows container:python:3.7-windowsservercore-1809
  • macOS PYTHON:3.7.2
  • FreeBSD PYTHON:3.6
  • FreeBSD PYTHON:3.7
  • Lint
  • Linux container:python:3.7-slim
  • Linux container:python:3.5-slim
  • Linux container:python:3.6-slim
  • Windows container:python:3.6-windowsservercore-1809
  • macOS PYTHON:3.6.8

@bors bors bot merged commit c98f813 into master Jul 2, 2019
@duckinator duckinator deleted the credits branch July 2, 2019 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@duckinator @nbraud