Customise import for DurHack DevPost and location strings #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSV import now supports a 15th column (index 14, column O in Excel) with the location of a team (e.g. 14.3). String is flexible for any format that logistics chooses.
This was used when table numbers were assigned automatically based on import order and is no longer needed now that location has to be specified.
Change previous number type to string in line with backend.
Involved stabbing me repeatedly with frontend flex-box shaped knives. But it works now I think 😀 (in Chrome at least)
The incremental table number concept no longer exists so this can be removed.
NB: uses new YesNoResponse type from handle-early-ranking-end branch.
tameTNT
changed the title
|
Note that the format given here is no longer accurate. See this line in durhack-jury/server/funcs/csv.go Line 90 in a947428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
Adapts the CSV import functionality to allow for a new
Locationfield (vs. the original auto-generatedTableNumber). The question for 'what is your table?' should be reordered on the imported devpost CSV so that it is the 15th column (index 14, column O in Excel) that contains the location info of a team (e.g. 14.3 of whatever logistics decides - the field is an unvalidated string so anything goes at the moment).After testing last year's DevPost CSV, this PR also addresses long project names overflowing from their containers on the judging page and the admin dashboard. That was fun to work out 🙂.
Still working on allowing locations to be edited on the admin side.