forked from parth23-dev/jury
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement bulk hiding projects (by guild or selection) #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admins can select as many projects as they like with checkboxes And then click hide selected.
I guess there was a purpose to the type switching from Array to Object... Why TypeScript/React allows that is anyone's guess.
Also add guild field to project input on client frontend
And the fix the stupid React type thing by adding ` || false` to handle the undefined behaviour.
- Click on stats block to refresh stats like hidden projects - Add text saying how many projects are selected - Sort guilds in dropdown - Notify of how many projects were un/hidden
- Explain how taking a break actually works - Add a dropdown option for selecting all projects on the admin page
Previously led to a null pointer panic
Best I can do atm in lieu of the full name/email of a judge
Seen numbers do not include skipped projects (Projects or Judges table)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to hide projects in bulk (including by guild) by selecting lots of them as seen in the screenshot below:
This closes #3 🥳
The above also involved allowing the guild field of the projects to be specified (now separate from location - this is still a string though).
This PR also includes a bunch of UI tweaks to make the admin and judging process better. Lots of wording is also clarified throughout the UI.