Pass extra CLI args through to ESLint (facebook#20250)

These now work: ``` yarn run lint --fix yarn run linc --fix ```
dudulasry · Nov 13, 2020 · 73bf2d6 · 73bf2d6
1 parent b44e4b1
commit 73bf2d6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/scripts/eslint/index.js b/scripts/eslint/index.js
@@ -64,13 +64,14 @@ function intersect(files, patterns) {
   return [...new Set(intersection)];
 }
 
-function runESLint({onlyChanged}) {
+function runESLint({onlyChanged, ...options}) {
   if (typeof onlyChanged !== 'boolean') {
     throw new Error('Pass options.onlyChanged as a boolean.');
   }
   const {errorCount, warningCount, output} = runESLintOnFilesWithOptions(
     allPaths,
-    onlyChanged
+    onlyChanged,
+    options
   );
   console.log(output);
   return errorCount === 0 && warningCount === 0;

diff --git a/scripts/tasks/eslint.js b/scripts/tasks/eslint.js
@@ -7,6 +7,7 @@
 
 'use strict';
 
+const minimist = require('minimist');
 const runESLint = require('../eslint');
 
 console.log('Linting all files...');
@@ -15,7 +16,8 @@ if (!process.env.CI) {
   console.log('Hint: run `yarn linc` to only lint changed files.');
 }
 
-if (runESLint({onlyChanged: false})) {
+const cliOptions = minimist(process.argv.slice(2));
+if (runESLint({onlyChanged: false, ...cliOptions})) {
   console.log('Lint passed.');
 } else {
   console.log('Lint failed.');

diff --git a/scripts/tasks/linc.js b/scripts/tasks/linc.js
@@ -7,11 +7,13 @@
 
 'use strict';
 
+const minimist = require('minimist');
 const runESLint = require('../eslint');
 
 console.log('Linting changed files...');
 
-if (runESLint({onlyChanged: true})) {
+const cliOptions = minimist(process.argv.slice(2));
+if (runESLint({onlyChanged: true, ...cliOptions})) {
   console.log('Lint passed for changed files.');
 } else {
   console.log('Lint failed for changed files.');