-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD-13627] Upgrade Portainer to work with Mesos 1.1.0 #53
Open
oli-hall
wants to merge
35
commits into
master
Choose a base branch
from
upgrade/mesos-1.1.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker version downloaded by get-docker was incompatible with the version of debian used previously, so docker daemon was unable to start.
Previously installed latest, which is too large a jump to be useful
Ensures mesos logs have sensible timestamps
Old pex was having issues with some of its dependencies. This should be safer going forward.
All build options have changed. Also appeared that wheelhouse dir was not being created as it should.
local user does not have permissions on cluster on VM to launch framework.
This allows the framework to be launched with the local user, rather than root.
build-executor was the same name as the build-executor script which built the executor. This runs the executor, so run- is a more accurate prefix.
oli-hall
changed the title
Upgrade Portainer to work with Mesos 1.1.0
[DD-13627] Upgrade Portainer to work with Mesos 1.1.0
Feb 16, 2017
oli-hall
changed the title
[DD-13627] Upgrade Portainer to work with Mesos 1.1.0
Upgrade Portainer to work with Mesos 1.1.0
Feb 20, 2017
nk412
reviewed
Feb 28, 2017
portainer/app/build.py
Outdated
@@ -1,16 +1,18 @@ | |||
"""The entrypoint to the portainer app. Spins up the a schedular instance and | |||
"""The entrypoint to the portainer app. Spins up the a scheduler instance and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the a scheduler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I may as well correct someone else's grammar while I'm at it :P
LGTM! |
nk412
changed the title
Upgrade Portainer to work with Mesos 1.1.0
[DD-13627] Upgrade Portainer to work with Mesos 1.1.0
Feb 28, 2017
Nice! Get's my vote. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://duedil.atlassian.net/browse/DD-13627
This updates Portainer to work with Mesos 1.1.0, and incorporates a couple of minor improvements (such as #10).
The main changes: the
pesos
python library has been removed in favour ofpymesos
, which uses the HTTP API used by Mesos from version 0.28.0 onwards. The changes here are mostly trivial (API calls take dictionaries rather than Mesos protobuf structures, changes in terminology from 'slave' to 'agent').As part of the upgrade, PEX has also been upgraded, and the VM installation has been tweaked to install Docker registry 2 and Docker 1.10.3 (as per production), as well as now being based upon Debian 8. The memory allocated to the VM has also been increased, as portainer builds were causing the Mesos Master process in the VM to be terminated with the original 1024MB.