Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use context in all http requests #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use context in all http requests #16

wants to merge 1 commit into from

Conversation

yurifedoseev
Copy link

HTTP requests require using context object for controlling requests lifetime: timeouts, cancel, graceful shutdown. If calling code doesn't require context it can use a stub via context.TODO()

@yurifedoseev yurifedoseev mentioned this pull request Feb 17, 2023
Open
@yurifedoseev
Copy link
Author

@dukex Hi, could you help to review this MR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yurifedoseev