-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export in interactive #298
Conversation
Signed-off-by: kadogo <[email protected]>
Signed-off-by: kadogo <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
==========================================
- Coverage 93.58% 90.16% -3.43%
==========================================
Files 29 31 +2
Lines 2806 3345 +539
==========================================
+ Hits 2626 3016 +390
- Misses 139 267 +128
- Partials 41 62 +21 ☔ View full report in Codecov by Sentry. |
Nice contribution, thank you! |
Thank you and you are welcome, when I see your updates it looks much better than my "pull together" thing ^^ I will give the new version a try in the week, based on the code I see window and stuff like that it sounds interesting ^^ |
Yes, my idea was that the user might not know that he will want to export the data later, so he might not add the option Not sure yet when I will release this as a next version. There is still some stuff that I would like to include. But you can install the master version using:
|
No problem, I'm not in a hurry. I took 1 year before giving a try to the PR ^^ I gave it a try to the command, and it's working well. |
Hello
I don't really know Go, so it was trial and error for the most of it.
It would fix #141, but you are free to do any modification to the PR.
I did a few little tests, and it looks like it is working as expected.
I'm pretty sure that the code would be better that what I have done, that, I think, is also a bit dirty...
When launching GDU the argument
-e
is used to define the path of the dump when we will pressS
(uppercase s) in the interactive mode.I didn't try to do a progress bar because I felt like it was another level, but the save looks pretty fast, so maybe it's alright.
Cheers