Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APY calculations to Sudoswap pools by Collection #1

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

andrewhong5297
Copy link
Contributor

@andrewhong5297 andrewhong5297 commented Nov 29, 2023

Is this linked to an existing issue
Issue described here #2

Fill out the following table describing your edits:

Original Query Updated Query Change Reasoning
2615781 2615783 sum weekly fees, multiply by 52, then divide by TVL assuming current floor price and ETH value. this is an approximate dynamic way of understanding APY

Provide any other context or screenshots that explain or justify the changes above:

Results look like this:
image

"Different pricing curves means that TVL of pools is not exactly just a linear calculation, we may want to reflect that before dividing in the future."


Note to contributor:

Make sure your PR edits the original query_id.sql file with the new query text. If you are proposing adding a new query completely, make sure to add it to queries.yml and as a file in /queries as well.

Thanks for contributing! 🙏

@andrewhong5297 andrewhong5297 changed the title Make DEX traders chart more well defined Add APY calculations to Sudoswap pools by Collection Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant