Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service metadata in iam_definition.json #235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smrojas
Copy link

@smrojas smrojas commented Aug 7, 2023

Problem

Observed UNKNOWN_PREFIX - Unknown prefix bedrock from parliament. This is a new AWS service called Bedrock. We need to refresh the mappings with the most recent services.

Testing

Ran python utils/update_iam_data.py > parliament/iam_definition.json and looked for the bedrock service in the json

    "prefix": "bedrock",                                                                                                                                                    "privileges": [
      {
        "access_level": "Write",
        "description": "Grants permission to create a job for customizing the model with your custom training data",
        "privilege": "CreateModelCustomizationJob",
        "resource_types": [
          {
            "condition_keys": [],
            "dependent_actions": [],
            "resource_type": "custom-model*"
          },
          {
            "condition_keys": [],
            "dependent_actions": [],
            "resource_type": "foundation-model*"
          },
          {
            "condition_keys": [],
            "dependent_actions": [],
            "resource_type": "model-customization-job*"
          },
          {
            "condition_keys": [
              "aws:RequestTag/${TagKey}",
              "aws:TagKeys"
            ],
            "dependent_actions": [],
            "resource_type": ""
          }
        ]
      }

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2023

CLA assistant check
All committers have signed the CLA.

@iainelder
Copy link
Contributor

Superseded by #239. Now bedrock is part of the default definitions.

@zuBux
Copy link
Contributor

zuBux commented Jan 15, 2025

hey @iainelder,

The IAM definitions might need another update, looks like we're getting the following error on our side:

Unknown action bedrock:CreateFlow

bedrock as a service is recognised in 1.63 but this permission is not :)

@iainelder
Copy link
Contributor

iainelder commented Jan 15, 2025

@zuBux , I'd like to help, but I'm not an owner or official contributor to the repo. I don't have any power to update the default IAM definitions.

I think @rjcassara- can help. He handled it the last time by merging someone's proposed changes and creating a new GitHub release. See #230 .

In the meantime, you can update your local IAM definitions using the steps described in "Updating the privilege info" in the README. I contributed that section last year in #240. It might still work for you. :-)

@zuBux
Copy link
Contributor

zuBux commented Jan 15, 2025

hey @iainelder,

Thanks for the info! I'll update the IAM definition and submit a PR then :D. I prefer this change upstream to be honest because then we can just bump the version in pip instead of creating local builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants