Merge pull request #149 from duo-labs/fix/update-webauthn-v2.4.0

fix/update-webauthn-v2.4.0
duo-labs · Dec 5, 2024 · 0e805a3 · 0e805a3
2 parents fad5eb3 + c388eb4
commit 0e805a3
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 11 deletions.
diff --git a/Pipfile.lock b/Pipfile.lock
diff --git a/_app/homepage/services/registration.py b/_app/homepage/services/registration.py
@@ -19,6 +19,7 @@
     AuthenticatorSelectionCriteria,
     AuthenticatorAttachment,
     PublicKeyCredentialDescriptor,
+    PublicKeyCredentialHint,
     ResidentKeyRequirement,
 )
 from webauthn.helpers.cose import COSEAlgorithmIdentifier
@@ -110,6 +111,8 @@ def generate_registration_options(
             if "rs256" in algorithms:
                 supported_pub_key_algs.append(COSEAlgorithmIdentifier.RSASSA_PKCS1_v1_5_SHA_256)
 
+        _hints = [PublicKeyCredentialHint(hint) for hint in hints]
+
         registration_options = generate_registration_options(
             rp_id=settings.RP_ID,
             rp_name=settings.RP_NAME,
@@ -125,6 +128,7 @@ def generate_registration_options(
                 )
                 for cred in existing_credentials
             ],
+            hints=_hints,
         )
 
         # py_webauthn will default to all supported algorithms on an empty `algorithms` list

diff --git a/_app/homepage/static/js/simplewebauthn-browser.12.0.0.umd.min.js b/_app/homepage/static/js/simplewebauthn-browser.12.0.0.umd.min.js