Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/decouple-reg-hints-and-attachment #150

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

MasterKale
Copy link
Collaborator

@MasterKale MasterKale commented Dec 5, 2024

This PR decouples the setting of authenticatorAttachment to whatever the contents of hints is.

Screenshots

Setting conflicting attachment and hints...

Screenshot 2024-12-05 at 11 08 59 AM

...will no longer override attachment based on hints, to help power users follow how browser/platform/etc... evolve to handle such combinations of options:

Screenshot 2024-12-05 at 11 08 42 AM

Fixes #142 and #155.

@MasterKale MasterKale force-pushed the fix/decouple-reg-hints-and-attachment branch from 8f9cace to 52c3bf7 Compare December 5, 2024 18:55
@MasterKale MasterKale merged commit 657c2bc into master Dec 5, 2024
1 check passed
@MasterKale MasterKale deleted the fix/decouple-reg-hints-and-attachment branch December 5, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silently setting authenticator attachment with hints may cause confusion.
1 participant