Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove memoize-sync #8

Merged
merged 2 commits into from
Mar 23, 2016
Merged

remove memoize-sync #8

merged 2 commits into from
Mar 23, 2016

Conversation

stephenmathieson
Copy link
Contributor

@dominicbarnes @matthewmueller

this is blocking atm... cant deploy because duo is broken

closes #7, ref duojs/duo#506

@dominicbarnes
Copy link
Contributor

Probably just best to switch to v2.0.0

@stephenmathieson
Copy link
Contributor Author

idk if 2.0.0 works, nor do i even know why we use this thing

@stephenmathieson
Copy link
Contributor Author

plus 0.0.2 -> 2.0.0 is a huge bump im not comfortable making for no apparent reason

@dominicbarnes
Copy link
Contributor

I guess we can ditch it, but it's saving us CPU cycles when we're parsing dependencies. The tests we have should confirm whether or not it still works.

@dominicbarnes dominicbarnes merged commit aa7fba5 into master Mar 23, 2016
@dominicbarnes dominicbarnes deleted the removememoizesync branch March 23, 2016 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

memoize-sync is broken or something
2 participants