Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate the occurrences of 'failed to receive candidate' error #1439

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

goshawk-3
Copy link
Contributor

@goshawk-3 goshawk-3 commented Jul 12, 2022

fixes #1438

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #1439 (6655b9e) into master (828364b) will decrease coverage by 10.27%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1439       +/-   ##
===========================================
- Coverage   50.51%   40.24%   -10.28%     
===========================================
  Files         145      146        +1     
  Lines        7544     9622     +2078     
===========================================
+ Hits         3811     3872       +61     
- Misses       3066     5123     +2057     
+ Partials      667      627       -40     
Impacted Files Coverage Δ
pkg/core/consensus/testing/node.go 0.00% <0.00%> (-93.55%) ⬇️
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/core/consensus/testing/utils.go 0.00% <0.00%> (-75.61%) ⬇️
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/gql/query/transactions.go 13.43% <0.00%> (-52.55%) ⬇️
pkg/core/consensus/selection/handler.go 33.33% <0.00%> (-44.93%) ⬇️
pkg/util/nativeutils/eventbus/eventbus.go 57.14% <0.00%> (-42.86%) ⬇️
pkg/rpc/client/session.go 26.19% <0.00%> (-42.39%) ⬇️
pkg/rpc/client/client.go 3.73% <0.00%> (-36.61%) ⬇️
... and 168 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ebd6cb...6655b9e. Read the comment docs.

@goshawk-3 goshawk-3 changed the title Report as a warning an event of discarding newblock while in a reduction Mitigate the occurrences of 'failed to receive candidate' error Jul 15, 2022
@goshawk-3 goshawk-3 marked this pull request as ready for review July 18, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mitigate the occurrences of 'failed to receive candidate' error
3 participants