Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings #775

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix clippy warnings #775

merged 1 commit into from
Oct 17, 2023

Conversation

moCello
Copy link
Member

@moCello moCello commented Oct 16, 2023

Resolves #774

@moCello moCello requested a review from ureeves October 16, 2023 17:02
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #775 (b003ab7) into master (d3bcc6a) will increase coverage by 0.01%.
The diff coverage is 80.76%.

❗ Current head b003ab7 differs from pull request most recent head 1b63afc. Consider uploading reports for the commit 1b63afc to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
+ Coverage   84.95%   84.96%   +0.01%     
==========================================
  Files          57       57              
  Lines        4040     4037       -3     
==========================================
- Hits         3432     3430       -2     
+ Misses        608      607       -1     
Files Coverage Δ
src/commitment_scheme/kzg10/key.rs 84.28% <ø> (+0.39%) ⬆️
src/commitment_scheme/kzg10/srs.rs 81.94% <100.00%> (ø)
src/composer.rs 90.57% <100.00%> (+0.03%) ⬆️
src/composer/compiler.rs 99.44% <100.00%> (-0.01%) ⬇️
src/composer/prover.rs 95.33% <100.00%> (-0.03%) ⬇️
src/fft/polynomial.rs 46.82% <100.00%> (+0.36%) ⬆️
src/fft/evaluations.rs 25.00% <0.00%> (ø)
src/composer/compiler/compress.rs 86.04% <86.66%> (+0.55%) ⬆️
src/runtime.rs 16.66% <0.00%> (-2.09%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3bcc6a...1b63afc. Read the comment docs.

@moCello moCello removed the request for review from ureeves October 16, 2023 17:05
@moCello moCello marked this pull request as draft October 16, 2023 17:05
@moCello moCello marked this pull request as ready for review October 17, 2023 07:43
@moCello moCello requested review from ureeves and HDauven October 17, 2023 07:43
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moCello moCello merged commit 29c9500 into master Oct 17, 2023
5 checks passed
@moCello moCello deleted the mocello/fix_clippy branch October 17, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix clippy warnings
2 participants