[MS connector] Use provider configuration from connector #6151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description --- Instead of fetching config, use the one already fetched by connector Note: did not find an easy way to type, so went with an `as`. Open to alternate solutions if this seems too liberal
spolu
reviewed
Jul 9, 2024
| @@ -207,6 +207,10 @@ export class ConnectorResource extends BaseResource<ConnectorModel> { | |||
| return this.errorType === "third_party_internal_error"; | |||
| } | |||
|
|
|||
| get providerConfiguration(): ConnectorProviderConfigurationResource | null { | |||
There was a problem hiding this comment.
You should be able to type with the mapping in the strategy file. We def don't want this generic type here since this is meant to be used in each separate connectors 👍
There was a problem hiding this comment.
I had looked into that before submitting. I don't think it can be done easily.
At some point, we get a connector by id, and that's runtime, so the connector object can't be typed as a XXXConnectorResource itself. Thus, at the time i'm not sure how its provider configuration can be typed as well
Going to have a second look
|
After a few months, closing (not worth reworking on) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of fetching config, use the one already fetched by connector
Note: did not find an easy way to type, so went with an
as. Open to alternate solutions if this seems too liberal