update fragment specifiers/allow spaces in metavariable declarations #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `pat_param` specifier from 2021 edition - Add `expr_2021` specifier from 2024 edition: https://doc.rust-lang.org/edition-guide/rust-2024/macro-fragment-specifiers.html - This specifier is currently unstable but the name seems to be confirmed: rust-lang/rust#123742 (comment) - Require a word boundary (`\b`) at the end of the specifier - Replace `[A-Za-z0-9_]` with `\w` - Allow spaces before and after the `:` in metavariable declarations - Add tests for the new specifiers and spacing
|
Looks great, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a Rust project with macros that put a space after the colon in a macro metavariable declaration (e.g.
$var: literal) and noticed the fragment specifier didn't get thevariable.other.metavariable.specifier.rustscope. Additionally,pat_paramisn't in the list sopatwould get the scope but not_param. Plus Rust 2024 edition is adding anexpr_2021fragment specifier for backward compatibility with macros written for 2021 edition.pat_paramspecifier from 2021 editionexpr_2021specifier from 2024 edition: https://doc.rust-lang.org/edition-guide/rust-2024/macro-fragment-specifiers.htmlexprmacro fragment specifier for Rust 2024 rust-lang/rust#123742 (comment)\b) at the end of the specifier[A-Za-z0-9_]with\w:in metavariable declarations