-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(blog): reorder the default navigation items, introduce a 'Latest' component to display the most recent blog posts, 'New' flag to indicate recent posts #545
Conversation
Reviewer's Guide by SourceryThis PR implements several UI improvements and code quality updates across the blog application. The main changes include adding a new "Latest" posts component to the homepage, introducing a "New" flag for recent posts, and performing code cleanup with consistent formatting and type improvements. Updated class diagram for the Post typeclassDiagram
class Post {
+string slug
+string title
+Date date
+string category
+string category_slug
+string[] tags
+string[] tags_slug
+string thumbnail
+string author
+string content
+string excerpt
+string edit_url
+string series
+any [key: string]
}
note for Post "Added 'thumbnail' attribute"
Class diagram for the new Latest componentclassDiagram
class Latest {
+LatestProps props
+getPosts(limit: int) Post[]
+Latest(props: LatestProps)
}
class LatestProps {
+string className
}
class Post {
+string slug
+string title
+Date date
+string category
+string category_slug
+string[] tags
+string[] tags_slug
+string thumbnail
+string author
+string content
+string excerpt
+string edit_url
+string series
+any [key: string]
}
Latest --> LatestProps
Latest --> Post
note for Latest "New component to display latest posts on homepage"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @duyet - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider separating formatting changes (semicolons, quotes) into a separate PR from functional changes to make reviews more focused and efficient.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Update the blog UI by adding a 'Latest' component to showcase recent posts and a 'New' flag for recent posts in the 'YearPost' component. Enhance the navigation menu with a 'Feed' link and update the 'Thumb' component to support unoptimized images.
New Features:
Enhancements: