chore: add updates #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: AGNT redemption unleash
refactor: oracle
V0.0.1 internal audit
DavidMinarsch
commented
Dec 1, 2024
contracts/MemeBase.sol
Outdated
| function _redemptionSetup(address[] memory accounts, uint256[] memory amounts) private { | ||
| require(accounts.length == amounts.length); | ||
|
|
||
| redemptionAddress = address(new Meme("Agent Token", "AGENT", DECIMALS, MIN_TOTAL_SUPPLY)); |
There was a problem hiding this comment.
Suggested change
| redemptionAddress = address(new Meme("Agent Token", "AGENT", DECIMALS, MIN_TOTAL_SUPPLY)); | |
| redemptionAddress = address(new Meme("Agent Token II", "AGNT II", DECIMALS, 1_000_000_000 ether)); |
There was a problem hiding this comment.
The original AGNT has 1bn supply. Then 500m got purged (as no-one could collect).
There was a problem hiding this comment.
Ah right, I'm getting lost in those zero-s.
There was a problem hiding this comment.
Let's get all the values from the old contract itself.
contracts/MemeBase.sol
Outdated
|
|
||
| /// @dev AGNT token redemption unleash. | ||
| function _redemption() private { | ||
| uint256 amountForLP = (MIN_TOTAL_SUPPLY * LP_PERCENTAGE) / 100; |
There was a problem hiding this comment.
Take from vars on struct, not hard coded
There was a problem hiding this comment.
How about we just view it from the original contract? I think this is the most trustless way to do it.
contracts/MemeBase.sol
Outdated
| uint256 heartersAmount = MIN_TOTAL_SUPPLY - amountForLP; | ||
|
|
||
| // Create Uniswap pair with LP allocation | ||
| (address pool, uint256 liquidity) = _createUniswapPair(redemptionAddress, REDEMPTION_AMOUNT, amountForLP); |
There was a problem hiding this comment.
again take from vars, not hard coded. Just introduces potential for error
contracts/MemeBase.sol
Outdated
| // Record the actual meme unleash time | ||
| memeSummon.unleashTime = block.timestamp; | ||
| // Record the hearters distribution amount for this meme | ||
| memeSummon.heartersAmount = heartersAmount; |
Test oracle
chore: deployment scripts
kupermind
approved these changes
Dec 11, 2024
77ph
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.