chore: ascendance feature extraction #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidMinarsch
commented
Oct 28, 2024
| @@ -96,7 +96,7 @@ interface IUniswap { | |||
| /// - Agent Jones would forget to collectThisMeme | |||
| /// - Any agent would call purgeThisMeme, which would cause Agent Jones's allocation of 125_000_000 worth of $SMTH to be burned. | |||
| contract MemeBase { | |||
| event OLASBridgedForBurn(address indexed olas, uint256 amount); | |||
| event OLASJourneyToAscendance(address indexed olas, uint256 amount); | |||
There was a problem hiding this comment.
Renamed for the lore
|
|
||
| // Burn OLAS | ||
| _bridgeAndBurn(OLASAmount); | ||
| scheduledForAscendance += burnPercentageOfUSDC; |
There was a problem hiding this comment.
We don't send this here, to improve UX for unleashThisMeme and also to have less bridging transactions ...
kupermind
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.