chore: further refactor to account for multi-chain version #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidMinarsch
commented
Oct 29, 2024
| @@ -73,6 +73,11 @@ abstract contract MemeBase is MemeFactory { | |||
| address public immutable l2TokenRelayer; | |||
| // Oracle address | |||
| address public immutable oracle; | |||
| // Token transfer gas limit for L1 | |||
There was a problem hiding this comment.
This is base specific
| l2TokenRelayer = _l2TokenRelayer; | ||
| oracle = _oracle; | ||
| balancerPoolId = _balancerPoolId; | ||
| } | ||
|
|
||
| /// @dev Buys USDC on UniswapV2 using ETH amount. | ||
| /// @param ethAmount Input ETH amount. | ||
| /// @param nativeTokenAmount Input ETH amount. |
There was a problem hiding this comment.
renamed everything to nativeToken (payment token) and referenceToken (stablecoin or some other coin we "store" things in until burn)
| @@ -86,20 +86,15 @@ abstract contract MemeFactory { | |||
| uint256 public constant LP_PERCENTAGE = 50; | |||
| // L1 OLAS Burner address | |||
| address public constant OLAS_BURNER = 0x51eb65012ca5cEB07320c497F4151aC207FEa4E0; | |||
| // Token transfer gas limit for L1 | |||
There was a problem hiding this comment.
specific to chain, moved up
| router = _router; | ||
| factory = _factory; | ||
| balancerVault = _balancerVault; | ||
| minNativeTokenValue = _minNativeTokenValue; |
There was a problem hiding this comment.
#8 removed as per
There was a problem hiding this comment.
But now it's not set at all. This minimum amount is chain specific and will vary.
test: testing celo contract
refactor: finalizing both approaches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.