Mes release 9990 practice mode modal mot fix (#1735)

* Fixed a bug where practice mode would not cancel the spinner and not allow the user to further use the feature

* linting

* update version number

config.xml

@@ -1,5 +1,5 @@
 <?xml version='1.0' encoding='utf-8'?>
-<widget id="uk.gov.dvsa.drivingexaminerservices" version="4.14.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
+<widget id="uk.gov.dvsa.drivingexaminerservices" version="4.14.0.1" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
     <name>DES</name>
     <description>An application for DVSA driving examiners to conduct driving tests digitally</description>
     <content src="index.html" />

ios/App/App/Info.plist

@@ -17,7 +17,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>4.14.0.0</string>
+	<string>4.14.0.1</string>
 	<key>CFBundleURLTypes</key>
 	<array>
 		<dict>
@@ -40,7 +40,7 @@
         <string>companyportal</string>
     </array>
 	<key>CFBundleVersion</key>
-	<string>4.14.0.0</string>
+	<string>4.14.0.1</string>
 	<key>LSRequiresIPhoneOS</key>
 	<true/>
 	<key>NSCameraUsageDescription</key>

src/app/pages/waiting-room-to-car/components/vehicle-registration/vehicle-registration.ts

@@ -122,10 +122,16 @@ export class VehicleRegistrationComponent implements OnChanges {
       // If the user indicates that the MOT failed, load the failed MOT modal
       if (fakeModalReturn === PracticeModeMOTType.FAILED) {
         await this.loadFailedMOTModal();
+        // If the modal was cancelled, stop the spinner and return
+        if (this.modalData === ModalEvent.CANCEL) {
+          this.isSearchingForMOT = false;
+          return;
+        }
       }
 
       // If the user cancelled the practice mode modal, reset motData and stop the spinner
       if (fakeModalReturn === ModalEvent.CANCEL) {
+        this.isSearchingForMOT = false;
         this.motData = null;
         return;
       }
@@ -136,6 +142,13 @@ export class VehicleRegistrationComponent implements OnChanges {
       // Make a mock API call to get the MOT result based on the practice mode response
       this.motApiService
         .getMockResultByIdentifier(value, fakeModalReturn as PracticeModeMOTType)
+        .pipe(
+          takeUntil(this.abortSubject),
+          finalize(() => {
+            // Stop the search spinner
+            this.isSearchingForMOT = false;
+          })
+        )
         .subscribe((val: MotHistoryWithStatus) => {
           // Assign the mock API response to the motData property
           this.motData = val;