biome implementation of no implicit any

biome.json

@@ -72,6 +72,19 @@
           }
         }
       }
+    },
+    {
+      "include": [
+        "**/*.spec.ts"
+      ],
+      "linter": {
+        "enabled": true,
+        "rules": {
+          "suspicious": {
+            "noExplicitAny": "off"
+          }
+        }
+      }
     }
   ]
 }

src/app/__tests__/sentry-error-handler.spec.ts

@@ -82,7 +82,7 @@ describe('SentryIonicErrorHandler', () => {
       );
       spyOn(sentryErrorHandler.logHelper, 'createLog').and.returnValue(mockLog);
 
-      await sentryErrorHandler.handleError({ err: 'some error' });
+      await sentryErrorHandler.handleError({ message: 'some error' });
       expect(sentryErrorHandler.store$.dispatch).toHaveBeenCalledWith(SaveLog({ payload: mockLog }));
     });
     it('should not call to any provider if an instance of HttpErrorResponse', async () => {

src/app/app.module.ts

@@ -87,17 +87,7 @@ export function localStorageSyncReducer(reducer: ActionReducer<StoreModel>): Act
   })(reducer);
 }
 
-export interface AppState {
-  journal: JournalState;
-  appInfo: AppInfoState;
-  appConfig: AppConfigState;
-  tests: TestsState;
-  rekeySearch: RekeySearchState;
-  delegatedRekeySearch: DelegatedSearchState;
-  examinerRecords: ExaminerRecordsState;
-}
-
-const reducers: ActionReducerMap<AppState> = {
+const reducers: ActionReducerMap<unknown> = {
   journal: journalReducer,
   appInfo: appInfoReducer,
   appConfig: appConfigReducer,
@@ -107,7 +97,7 @@ const reducers: ActionReducerMap<AppState> = {
   examinerRecords: examinerRecordsReducer,
 };
 
-const metaReducers: MetaReducer<AppState>[] = [];
+const metaReducers: MetaReducer<unknown>[] = [];
 const enableDevTools = environment && (environment as EnvironmentFile).enableDevTools;
 const enableRehydrationPlugin = environment && (environment as EnvironmentFile).enableRehydrationPlugin;
 

src/app/pages/back-to-office/__tests__/back-to-office.analytics.effects.spec.ts

@@ -2,7 +2,7 @@ import { TestBed, waitForAsync } from '@angular/core/testing';
 import { Application } from '@dvsa/mes-journal-schema';
 import { TestCategory } from '@dvsa/mes-test-schema/category-definitions/common/test-category';
 import { provideMockActions } from '@ngrx/effects/testing';
-import { Store, StoreModule } from '@ngrx/store';
+import { Action, Store, StoreModule } from '@ngrx/store';
 import { AnalyticsProviderMock } from '@providers/analytics/__mocks__/analytics.mock';
 import { AnalyticsProvider } from '@providers/analytics/analytics';
 import { AnalyticRecorded } from '@providers/analytics/analytics.actions';
@@ -33,7 +33,7 @@ import { BackToOfficeAnalyticsEffects } from '../back-to-office.analytics.effect
 describe('BackToOfficeAnalyticsEffects', () => {
   let effects: BackToOfficeAnalyticsEffects;
   let analyticsProviderMock: AnalyticsProvider;
-  let actions$: ReplaySubject<any>;
+  let actions$: ReplaySubject<Action>;
   let store$: Store<StoreModel>;
   const screenName = AnalyticsScreenNames.BACK_TO_OFFICE;
   const mockApplication: Application = {

src/app/pages/candidate-details/__tests__/candidate-details.analytics.effects.spec.ts

@@ -2,7 +2,7 @@ import { TestBed, waitForAsync } from '@angular/core/testing';
 import { TestSlot } from '@dvsa/mes-journal-schema';
 import { TestCategory } from '@dvsa/mes-test-schema/category-definitions/common/test-category';
 import { provideMockActions } from '@ngrx/effects/testing';
-import { Store, StoreModule } from '@ngrx/store';
+import { Action, Store, StoreModule } from '@ngrx/store';
 import { CandidateDetailsAnalyticsEffects } from '@pages/candidate-details/candidate-details.analytics.effects';
 import { AnalyticsProviderMock } from '@providers/analytics/__mocks__/analytics.mock';
 import { AnalyticsProvider } from '@providers/analytics/analytics';
@@ -30,7 +30,7 @@ import { ReplaySubject } from 'rxjs';
 describe('CandidateDetailsAnalyticsEffects', () => {
   let effects: CandidateDetailsAnalyticsEffects;
   let analyticsProviderMock: AnalyticsProvider;
-  let actions$: ReplaySubject<any>;
+  let actions$: ReplaySubject<Action>;
   let store$: Store<StoreModel>;
   const screenName = AnalyticsScreenNames.CANDIDATE_DETAILS;
   const mockTestSlot = {

src/app/pages/candidate-licence/__tests__/candidate-licence.analytics.effects.spec.ts

@@ -3,7 +3,7 @@ import { Router } from '@angular/router';
 import { Application } from '@dvsa/mes-journal-schema';
 import { TestCategory } from '@dvsa/mes-test-schema/category-definitions/common/test-category';
 import { provideMockActions } from '@ngrx/effects/testing';
-import { Store, StoreModule } from '@ngrx/store';
+import { Action, Store, StoreModule } from '@ngrx/store';
 import { CandidateLicenceAnalyticsEffects } from '@pages/candidate-licence/candidate-licence.analytics.effects';
 import { TestFlowPageNames } from '@pages/page-names.constants';
 import { AnalyticsProviderMock } from '@providers/analytics/__mocks__/analytics.mock';
@@ -27,7 +27,7 @@ import * as candidateLicenceActions from '../candidate-licence.actions';
 describe('CommunicationAnalyticsEffects', () => {
   let effects: CandidateLicenceAnalyticsEffects;
   let analyticsProviderMock: AnalyticsProvider;
-  let actions$: ReplaySubject;
+  let actions$: ReplaySubject<Action>;
   let store$: Store<StoreModel>;
   const screenName = AnalyticsScreenNames.CANDIDATE_LICENCE_INFO;
   const mockApplication: Application = {

src/app/pages/communication/__tests__/communication.analytics.effects.spec.ts

@@ -3,7 +3,7 @@ import { Router } from '@angular/router';
 import { Application } from '@dvsa/mes-journal-schema';
 import { TestCategory } from '@dvsa/mes-test-schema/category-definitions/common/test-category';
 import { provideMockActions } from '@ngrx/effects/testing';
-import { Store, StoreModule } from '@ngrx/store';
+import { Action, Store, StoreModule } from '@ngrx/store';
 import { TestFlowPageNames } from '@pages/page-names.constants';
 import { AnalyticsProviderMock } from '@providers/analytics/__mocks__/analytics.mock';
 import { AnalyticsProvider } from '@providers/analytics/analytics';
@@ -39,7 +39,7 @@ import { CommunicationAnalyticsEffects } from '../communication.analytics.effect
 describe('CommunicationAnalyticsEffects', () => {
   let effects: CommunicationAnalyticsEffects;
   let analyticsProviderMock: AnalyticsProvider;
-  let actions$: ReplaySubject<any>;
+  let actions$: ReplaySubject<Action>;
   let store$: Store<StoreModel>;
   const screenName = AnalyticsScreenNames.COMMUNICATION;
   const screenNamePM = `${GoogleAnalyticsEventPrefix.PRACTICE_MODE}_${AnalyticsScreenNames.COMMUNICATION}`;

src/app/pages/communication/__tests__/communication.effects.spec.ts

@@ -1,6 +1,6 @@
 import { TestBed, waitForAsync } from '@angular/core/testing';
 import { provideMockActions } from '@ngrx/effects/testing';
-import { Store, StoreModule } from '@ngrx/store';
+import { Action, Store, StoreModule } from '@ngrx/store';
 import * as testStatusActions from '@store/tests/test-status/test-status.actions';
 import * as testsActions from '@store/tests/tests.actions';
 import { ReplaySubject } from 'rxjs';
@@ -9,7 +9,7 @@ import { CommunicationEffects } from '../communication.effects';
 
 describe('CommunicationEffects', () => {
   let effects: CommunicationEffects;
-  let actions$: ReplaySubject<any>;
+  let actions$: ReplaySubject<Action>;
   const currentSlotId = '1234';
 
   beforeEach(waitForAsync(() => {

src/app/pages/confirm-test-details/__tests__/confirm-test-details.analytics.effects.spec.ts

@@ -1,6 +1,6 @@
 import { TestBed, waitForAsync } from '@angular/core/testing';
 import { provideMockActions } from '@ngrx/effects/testing';
-import { Store, StoreModule } from '@ngrx/store';
+import { Action, Store, StoreModule } from '@ngrx/store';
 import { testsReducer } from '@store/tests/tests.reducer';
 import { ReplaySubject } from 'rxjs';
 
@@ -25,7 +25,7 @@ import * as confirmTestDetailsActions from '../confirm-test-details.actions';
 describe('ConfirmTestDetailsAnalyticsEffects', () => {
   let effects: ConfirmTestDetailsAnalyticsEffects;
   let analyticsProviderMock: AnalyticsProvider;
-  let actions$: ReplaySubject<any>;
+  let actions$: ReplaySubject<Action>;
   let store$: Store<StoreModel>;
   const screenName = AnalyticsScreenNames.CONFIRM_TEST_DETAILS;
 

src/app/pages/confirm-test-details/components/confirm-submit-modal/__tests__/submit-modal.spec.ts

@@ -35,7 +35,7 @@ describe('ConfirmSubmitModal', () => {
     });
 
     const mockValue = mockFile.mockSlotDetail();
-    spyOn(navMock, 'get').and.returnValue(mockValue);
+    spyOn(navMock, 'get').and.returnValue(mockValue.start);
     modalFixture = TestBed.createComponent(ConfirmSubmitModal);
     modalComponent = modalFixture.componentInstance;
     spyOn(modalComponent.modalController, 'dismiss').and.returnValue(Promise.resolve(true));

src/app/pages/dashboard/__tests__/dashboard.analytics.effects.spec.ts

@@ -13,7 +13,7 @@ import {
 } from '@providers/analytics/analytics.model';
 
 import { TestCategory } from '@dvsa/mes-test-schema/category-definitions/common/test-category';
-import { Store, StoreModule } from '@ngrx/store';
+import { Action, Store, StoreModule } from '@ngrx/store';
 import { UpdateAvailable } from '@pages/dashboard/components/update-available-modal/update-available-modal';
 import { AppConfigProviderMock } from '@providers/app-config/__mocks__/app-config.mock';
 import { AppConfigProvider } from '@providers/app-config/app-config';
@@ -31,7 +31,7 @@ import { DashboardAnalyticsEffects } from '../dashboard.analytics.effects';
 describe('DashboardAnalyticsEffects', () => {
   let effects: DashboardAnalyticsEffects;
   let analyticsProviderMock: AnalyticsProvider;
-  let actions$: ReplaySubject<any>;
+  let actions$: ReplaySubject<Action>;
   const screenName = AnalyticsScreenNames.DASHBOARD;
 
   beforeEach(waitForAsync(() => {

src/app/pages/debrief/__tests__/debrief.analytics.effects.spec.ts

@@ -1,7 +1,7 @@
 import { TestBed, waitForAsync } from '@angular/core/testing';
 import { TestCategory } from '@dvsa/mes-test-schema/category-definitions/common/test-category';
 import { provideMockActions } from '@ngrx/effects/testing';
-import { Store, StoreModule, Action } from '@ngrx/store';
+import { Action, Store, StoreModule } from '@ngrx/store';
 import { AnalyticsProviderMock } from '@providers/analytics/__mocks__/analytics.mock';
 import { AnalyticsProvider } from '@providers/analytics/analytics';
 import { AnalyticRecorded } from '@providers/analytics/analytics.actions';

src/app/pages/debrief/__tests__/debrief.effects.spec.ts

@@ -1,7 +1,7 @@
 import { TestBed, waitForAsync } from '@angular/core/testing';
 import { TestCategory } from '@dvsa/mes-test-schema/category-definitions/common/test-category';
 import { provideMockActions } from '@ngrx/effects/testing';
-import { Store, StoreModule, Action } from '@ngrx/store';
+import { Action, Store, StoreModule } from '@ngrx/store';
 import { ActivityCodes } from '@shared/models/activity-codes';
 import { StoreModel } from '@shared/models/store.model';
 import * as activityCodeActions from '@store/tests/activity-code/activity-code.actions';

src/app/pages/debrief/components/driving-faults-debrief-card/__tests__/driving-faults-debrief-card.spec.ts

@@ -81,10 +81,10 @@ describe('DrivingFaultsDebriefCardComponent', () => {
         const drivingFaultsLabels = fixture.debugElement.queryAll(By.css('#driving-fault .counter-label'));
         const drivingFaultCount = fixture.debugElement.query(By.css('ion-text.fault-heading')).nativeElement;
         expect(drivingFaultsLabels[0].nativeElement.innerHTML.trim()).toBe(
-          (<any>welshTranslations).debrief.competencies.useOfSpeed
+          welshTranslations.debrief.competencies.useOfSpeed
         );
         expect(drivingFaultsLabels[1].nativeElement.innerHTML.trim()).toBe(
-          (<any>welshTranslations).debrief.competencies.signalsTimed
+          welshTranslations.debrief.competencies.signalsTimed
         );
         expect(drivingFaultCount.innerHTML).toBe(drivingFaults.length.toString());
         done();

src/app/pages/debrief/components/safety-and-balance-card/__tests__/safety-and-balance-card.cat-a-mod2.spec.ts

@@ -69,9 +69,7 @@ describe('SafetyAndBalanceCardCatAMod2Component', () => {
           By.css('#safety-and-balance-questions .counter-label')
         ).nativeElement;
 
-        expect(safetyQuestionText.innerHTML.trim()).toContain(
-          (englishTranslations).debrief.safetyAndBalanceQuestions.M4
-        );
+        expect(safetyQuestionText.innerHTML.trim()).toContain(englishTranslations.debrief.safetyAndBalanceQuestions.M4);
       });
 
       it('should show results in Welsh for a Welsh test', (done) => {
@@ -93,9 +91,7 @@ describe('SafetyAndBalanceCardCatAMod2Component', () => {
             By.css('#safety-and-balance-questions .counter-label')
           ).nativeElement;
 
-          expect(safetyQuestionText.innerHTML.trim()).toContain(
-            (welshTranslations).debrief.safetyAndBalanceQuestions.M4
-          );
+          expect(safetyQuestionText.innerHTML.trim()).toContain(welshTranslations.debrief.safetyAndBalanceQuestions.M4);
           done();
         });
       });

src/app/pages/debrief/components/serious-faults-debrief-card/__tests__/serious-faults-debrief-card.spec.ts

@@ -51,10 +51,10 @@ describe('SeriousFaultsDebriefCardComponent', () => {
         const drivingFaultsLabels = fixture.debugElement.queryAll(By.css('#serious-fault .counter-label'));
         const drivingFaultCount = fixture.debugElement.query(By.css('ion-text.fault-heading')).nativeElement;
         expect(drivingFaultsLabels[0].nativeElement.innerHTML.trim()).toBe(
-          (welshTranslations).debrief.competencies.useOfSpeed
+          welshTranslations.debrief.competencies.useOfSpeed
         );
         expect(drivingFaultsLabels[1].nativeElement.innerHTML.trim()).toBe(
-          (welshTranslations).debrief.competencies.signalsTimed
+          welshTranslations.debrief.competencies.signalsTimed
         );
         expect(drivingFaultCount.innerHTML).toBe(seriousFaults.length.toString());
         done();

src/app/pages/debrief/components/vehicle-checks-card-cat-b/__tests__/vehicle-checks-card.cat-b.spec.ts

@@ -105,7 +105,7 @@ describe('VehicleChecksCardCatBComponent', () => {
           translate.use('cy').subscribe(() => {
             fixture.detectChanges();
             const tellMeQuestionText = fixture.debugElement.query(By.css('#tell-me-question')).nativeElement;
-            const { tellMeQuestion, incorrect } = (welshTranslations).debrief;
+            const { tellMeQuestion, incorrect } = welshTranslations.debrief;
             expect(tellMeQuestionText.innerHTML.trim()).toBe(`${tellMeQuestion} - ${incorrect}`);
             done();
           });
@@ -128,7 +128,7 @@ describe('VehicleChecksCardCatBComponent', () => {
           translate.use('cy').subscribe(() => {
             fixture.detectChanges();
             const showMeQuestionText = fixture.debugElement.query(By.css('#show-me-question-outcome-df')).nativeElement;
-            const { showMeQuestion, incorrect } = (welshTranslations).debrief;
+            const { showMeQuestion, incorrect } = welshTranslations.debrief;
             const expectedTranslation = `${showMeQuestion} - ${incorrect}`;
             expect(showMeQuestionText.innerHTML.trim()).toBe(expectedTranslation);
             done();
@@ -150,7 +150,7 @@ describe('VehicleChecksCardCatBComponent', () => {
           translate.use('cy').subscribe(() => {
             fixture.detectChanges();
             const showMeQuestionText = fixture.debugElement.query(By.css('#show-me-question-outcome-s')).nativeElement;
-            const { showMeQuestion, seriousFault } = (welshTranslations).debrief;
+            const { showMeQuestion, seriousFault } = welshTranslations.debrief;
             const expectedTranslation = `${showMeQuestion} - ${seriousFault}`;
             expect(showMeQuestionText.innerHTML.trim()).toBe(expectedTranslation);
             done();
@@ -172,7 +172,7 @@ describe('VehicleChecksCardCatBComponent', () => {
           translate.use('cy').subscribe(() => {
             fixture.detectChanges();
             const showMeQuestionText = fixture.debugElement.query(By.css('#show-me-question-outcome-d')).nativeElement;
-            const { showMeQuestion, dangerousFault } = (welshTranslations).debrief;
+            const { showMeQuestion, dangerousFault } = welshTranslations.debrief;
             const expectedTranslation = `${showMeQuestion} - ${dangerousFault}`;
             expect(showMeQuestionText.innerHTML.trim()).toBe(expectedTranslation);
             done();

src/app/pages/debrief/components/vehicle-checks-card/__tests__/vehicle-checks-card.spec.ts

@@ -99,7 +99,7 @@ describe('VehicleChecksCardComponent', () => {
         const tellMeQuestionText = fixture.debugElement.query(By.css('#vehicle-checks .counter-label')).nativeElement;
 
         expect(tellMeQuestionText.innerHTML.trim()).toContain(
-          (englishTranslations).debrief.showMeTellMeQuestions[TestCategory.BE].S01
+          englishTranslations.debrief.showMeTellMeQuestions[TestCategory.BE].S01
         );
       });
 
@@ -121,8 +121,8 @@ describe('VehicleChecksCardComponent', () => {
           const tellMeQuestionText = fixture.debugElement.query(By.css('#vehicle-checks .counter-label')).nativeElement;
 
           expect(tellMeQuestionText.innerHTML.trim()).toContain(
-            (welshTranslations).debrief.showMeTellMeQuestions[TestCategory.BE].S01
-          )
+            welshTranslations.debrief.showMeTellMeQuestions[TestCategory.BE].S01
+          );
           done();
         });
       });

src/app/pages/delegated-rekey-search/__tests__/delegated-rekey-search.effects.spec.ts

@@ -2,7 +2,7 @@ import { HttpErrorResponse, HttpStatusCode } from '@angular/common/http';
 import { HttpClientTestingModule } from '@angular/common/http/testing';
 import { TestBed, waitForAsync } from '@angular/core/testing';
 import { provideMockActions } from '@ngrx/effects/testing';
-import { Store, StoreModule } from '@ngrx/store';
+import { Action, Store, StoreModule } from '@ngrx/store';
 import { AppConfigProviderMock } from '@providers/app-config/__mocks__/app-config.mock';
 import { AppConfigProvider } from '@providers/app-config/app-config';
 import { DelegatedRekeySearchProvider } from '@providers/delegated-rekey-search/delegated-rekey-search';
@@ -17,13 +17,13 @@ import * as delegatedRekeySearchActions from '../delegated-rekey-search.actions'
 import { DelegatedRekeySearchEffects } from '../delegated-rekey-search.effects';
 import { delegatedSearchReducer } from '../delegated-rekey-search.reducer';
 
-function asyncError(errorObject: any) {
+function asyncError(errorObject: { status: number; error: string }) {
   return defer(() => Promise.reject(errorObject));
 }
 
 describe('DelegatedRekeySearchEffects', () => {
   let effects: DelegatedRekeySearchEffects;
-  let actions$: ReplaySubject<any>;
+  let actions$: ReplaySubject<Action>;
   let delegatedRekeySearchProvider: DelegatedRekeySearchProvider;
   let searchProvider: SearchProvider;