Mes 8446 dark mode technical test #1139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
capacitor
matthew2564
reviewed
May 5, 2023
src/app/pages/candidate-licence/components/licence-data-error/licence-data-error.html
Outdated
Show resolved
Hide resolved
matthew2564
reviewed
May 5, 2023
matthew2564
reviewed
May 5, 2023
matthew2564
reviewed
May 5, 2023
src/app/pages/test-report/cat-home-test/test-report.cat-home-test.page.ts
Outdated
Show resolved
Hide resolved
matthew2564
reviewed
May 5, 2023
src/app/pages/waiting-room-to-car/components/accompaniment-card/accompaniment-card.html
Outdated
Show resolved
Hide resolved
matthew2564
reviewed
May 5, 2023
src/app/pages/waiting-room-to-car/components/accompaniment-card/accompaniment-card.ts
Outdated
Show resolved
Hide resolved
matthew2564
reviewed
May 5, 2023
src/components/common/datetime-input/date-time-input.component.scss
Outdated
Show resolved
Hide resolved
matthew2564
reviewed
May 5, 2023
Comment on lines
+11
to
+12
| @Input() | ||
| blackText?: boolean = false; | ||
|
|
There was a problem hiding this comment.
Can we not use the opposing/main logic instead of hard-setting the value?
There was a problem hiding this comment.
This needs to be there as the address appears both on the standard white/black background on search for completed as well as the lavender background on the communication page, where it always needs to be black in order to be readable.
matthew2564
reviewed
May 5, 2023
RLCorp
force-pushed
the
mes-8446-darkMode
branch
3 times, most recently
from
d4972da
to
31791a1
Compare
RLCorp
force-pushed
the
mes-8446-darkMode
branch
from
31791a1
to
15c2460
Compare
RLCorp
force-pushed
the
mes-8446-darkMode
branch
2 times, most recently
from
18e0fe6
to
a786b0e
Compare
RLCorp
force-pushed
the
mes-8446-darkMode
branch
2 times, most recently
from
42cce16
to
da97599
Compare
RLCorp
force-pushed
the
mes-8446-darkMode
branch
from
da97599
to
538c6cf
Compare
RLCorp
force-pushed
the
mes-8446-darkMode
branch
from
538c6cf
to
4925a24
Compare
RLCorp
force-pushed
the
mes-8446-darkMode
branch
from
103a380
to
c5adf8c
Compare
github-actions
bot
added
dependencies
RLCorp
force-pushed
the
mes-8446-darkMode
branch
from
c5adf8c
to
e9c4b9b
Compare
github-actions
bot
removed
the
dependencies
RLCorp
force-pushed
the
mes-8446-darkMode
branch
from
e9c4b9b
to
527ce92
Compare
RLCorp
force-pushed
the
mes-8446-darkMode
branch
from
41f06d8
to
9681037
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a deactivated technical prototype of Dark mode and changed static colours to a set of custom variables.
Checklist
Screenshots (optional)