mes-9923-noUselessConstructor

biome.json

@@ -58,7 +58,6 @@
             "noBannedTypes": "off",
             "noForEach": "off",
             "noThisInStatic": "off",
-            "noUselessConstructor": "off",
             "noExtraBooleanCast": "off",
             "useOptionalChain": "off",
             "noUselessCatch": "off"

src/app/pages/delegated-rekey-upload-outcome/delegated-rekey-upload-outcome.ts

@@ -28,7 +28,7 @@ interface DelegatedRekeyUploadOutcomePageState {
 export class DelegatedRekeyUploadOutcomePage extends BasePageComponent implements OnInit, ViewDidEnter {
   pageState: DelegatedRekeyUploadOutcomePageState;
 
-  constructor(injector: Injector) {
+  constructor(public injector: Injector) {
     super(injector);
   }
 

src/app/pages/rekey-upload-outcome/rekey-upload-outcome.page.ts

@@ -37,7 +37,7 @@ export class RekeyUploadOutcomePage extends BasePageComponent implements OnInit
   fromRekeySearch: boolean;
   subscription: Subscription = Subscription.EMPTY;
 
-  constructor(injector: Injector) {
+  constructor(public injector: Injector) {
     super(injector);
   }
 

src/app/shared/classes/__tests__/base-page.spec.ts

@@ -80,7 +80,7 @@ describe('BasePageComponent', () => {
     spyOn(logHelper, 'createLog');
 
     class BasePageClass extends BasePageComponent {
-      constructor(inj: Injector) {
+      constructor(public inj: Injector) {
         super(inj);
       }
     }

src/app/shared/classes/test-flow-base-pages/office/__tests__/office-base-page.spec.ts

@@ -187,7 +187,7 @@ describe('OfficeBasePageComponent', () => {
     spyOn(store$, 'dispatch');
 
     class BasePageClass extends OfficeBasePageComponent {
-      constructor(inj: Injector) {
+      constructor(public inj: Injector) {
         super(inj);
       }
     }

src/app/shared/classes/test-flow-base-pages/pass-finalisation/__tests__/pass-finalisation-base-page.spec.ts

@@ -106,7 +106,7 @@ describe('PassFinalisationPageComponent', () => {
     spyOn(store$, 'dispatch');
 
     class BasePageClass extends PassFinalisationPageComponent {
-      constructor(inj: Injector) {
+      constructor(public inj: Injector) {
         super(inj);
       }
     }

src/app/shared/classes/test-flow-base-pages/test-report/__tests__/test-report-base-page.spec.ts

@@ -102,7 +102,7 @@ describe('TestReportBasePageComponent', () => {
     injector = TestBed.inject(Injector);
 
     class BasePageClass extends TestReportBasePageComponent {
-      constructor(inj: Injector) {
+      constructor(public inj: Injector) {
         super(inj);
       }
     }

src/app/shared/classes/test-flow-base-pages/waiting-room-to-car/__tests__/waiting-room-to-car-base-page.spec.ts

@@ -164,7 +164,7 @@ describe('WaitingRoomToCarBasePageComponent', () => {
     spyOn(store$, 'dispatch');
 
     class BasePageClass extends WaitingRoomToCarBasePageComponent {
-      constructor(inj: Injector) {
+      constructor(public inj: Injector) {
         super(inj);
       }
     }

src/app/shared/classes/test-flow-base-pages/waiting-room-to-car/waiting-room-to-car-base-page.ts

@@ -150,7 +150,7 @@ export abstract class WaitingRoomToCarBasePageComponent extends PracticeableBase
   ];
 
   protected constructor(
-    injector: Injector,
+    public injector: Injector,
     @Inject(false) public loginRequired = false
   ) {
     super(injector, loginRequired);