add test: bnc.TestSimpleKline_NotExist

dwdwow · Mar 4, 2024 · 3be2904 · 3be2904
1 parent ee03d0c
commit 3be2904
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 8 deletions.
diff --git a/bnc/kline.go b/bnc/kline.go
@@ -71,7 +71,7 @@ func NewSimpleKlineFromStruct(k Kline) (kline SimpleKline) {
 }
 
 func (k SimpleKline) NotExist() bool {
-	return k[0] == 0
+	return k[1] == 0
 }
 
 func (k SimpleKline) OpenTime() int64 {

diff --git a/bnc/kline_test.go b/bnc/kline_test.go
@@ -104,14 +104,36 @@ func TestNewSimpleKline(t *testing.T) {
 
 }
 
+// TestNotExist tests the NotExist method of the SimpleKline type
 func TestSimpleKline_NotExist(t *testing.T) {
-	kline := SimpleKline{1}
-	if kline.NotExist() {
-		t.FailNow()
-	}
-	kline[0] = 0
-	if !kline.NotExist() {
-		t.FailNow()
+	tests := []struct {
+		name string
+		k    SimpleKline
+		want bool
+	}{
+		{
+			name: "not_exist",
+			k:    SimpleKline{1, 0, 2, 3, 4, 5, 6, 7, 8, 9, 10},
+			want: true,
+		},
+		{
+			name: "exist",
+			k:    SimpleKline{1, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10},
+			want: false,
+		},
+		{
+			name: "empty_kline",
+			k:    SimpleKline{},
+			want: true,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := tt.k.NotExist(); got != tt.want {
+				t.Errorf("NotExist() = %v, want %v", got, tt.want)
+			}
+		})
 	}
 }