Add thread deinit API #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweiller
force-pushed
the
thread-deinit
branch
2 times, most recently
from
162dabf to
9f1c177
Compare
dweiller
commented
Feb 21, 2024
dweiller
force-pushed
the
thread-deinit
branch
from
9f1c177 to
24019ac
Compare
In order to permit removing threads from the list while maintaining stable pointers to heaps a linked list is required. A future enchancement could replace the use of `std.heap.MemoryPool` with a custom allocation strategy, since the arena allocator backing a memory pool does not currently take advantage of the fact that the page allocator always allocates whole pages.
dweiller
force-pushed
the
thread-deinit
branch
from
24019ac to
c414c4d
Compare
dweiller
force-pushed
the
thread-deinit
branch
from
c414c4d to
3ed7f9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way heaps are handled for different threads is likely to change in order to solve #16, but in the meantime this is a simple solution to allow the user to remove threads from the heap list.