Fix AmiVector::nvec_ for size 0

dweindl · Oct 8, 2024 · 1eea0a6 · 1eea0a6
1 parent 2784887
commit 1eea0a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/test_sbml_semantic_test_suite.yml b/.github/workflows/test_sbml_semantic_test_suite.yml
@@ -5,6 +5,7 @@ on:
       - develop
       - master
       - release**
+      - fix_2534_empty_x
   pull_request:
     paths:
       - .github/workflows/test_sbml_semantic_test_suite.yml

diff --git a/src/vector.cpp b/src/vector.cpp
@@ -58,11 +58,9 @@ void AmiVector::copy(AmiVector const& other) {
 void AmiVector::synchroniseNVector(SUNContext sunctx) {
     if (nvec_)
         N_VDestroy_Serial(nvec_);
-    nvec_ = vec_.empty()
-                ? nullptr
-                : N_VMake_Serial(
-                      gsl::narrow<long int>(vec_.size()), vec_.data(), sunctx
-                  );
+    nvec_ = N_VMake_Serial(
+        gsl::narrow<long int>(vec_.size()), vec_.data(), sunctx
+    );
 }
 
 AmiVector::~AmiVector() {