Skip to content

Commit

Permalink
Re-enable gradient check for Fujita_SciSignal2010
Browse files Browse the repository at this point in the history
  • Loading branch information
dweindl committed Oct 24, 2024
1 parent f9699aa commit e2587ef
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tests/benchmark-models/test_petab_benchmark.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@
"Smith_BMCSystBiol2013",
# excluded due to excessive numerical failures
"Crauste_CellSystems2017",
"Fujita_SciSignal2010",
}
problems_for_gradient_check = list(sorted(problems_for_gradient_check))

Expand Down Expand Up @@ -177,6 +176,10 @@ class GradientCheckSettings:
settings["Brannmark_JBC2010"] = GradientCheckSettings(
ss_sensitivity_mode=amici.SteadyStateSensitivityMode.integrationOnly,
)
settings["Fujita_SciSignal2010"] = GradientCheckSettings(
atol_check=1e-10,
rtol_check=5e-4,
)
settings["Giordano_Nature2020"] = GradientCheckSettings(
atol_check=1e-6, rtol_check=1e-3, rng_seed=1
)
Expand Down

0 comments on commit e2587ef

Please sign in to comment.