Added interface for connecting parachain nodes to relaychain nodes. #35
Conversation
| @@ -70,11 +72,12 @@ def __init__(self, *args): | |||
|
|
|||
| self._stored.set_default(binary_url=self.config.get('binary-url'), | |||
| docker_tag=self.config.get('docker-tag'), | |||
| service_args=self.config.get('service-args')) | |||
| service_args=self.config.get('service-args'), | |||
| relay_rpc_urls=dict()) | |||
There was a problem hiding this comment.
Due to the data bug in departed hook we need a dict to for each url also store information which unit it is.
| @@ -8,8 +8,9 @@ | |||
|
|
|||
| class ServiceArgs(): | |||
|
|
|||
| def __init__(self, service_args: str): | |||
| def __init__(self, service_args: str, relay_rpc_urls: dict): | |||
There was a problem hiding this comment.
I'm not very happy with this solution. But could not come up with something more beautiful but still easy. We might probably need to do some surgency to this class anyway when we bring in snap support.
Maharacha
requested review from
erik78se,
jonathanudd and
jakobilobi
and removed request for
erik78se
|
Is there a link to the bug in the data passed in the interfaces? |
It's only in the Element chat so far. One guy there was able to reproduce this behavior. Now waiting for the Juju gurus to wake up. |
|
Another way of doing this would be to use the peer-relation. So that only the leader unit communicates with the interface and updates the app-data that the other units can read. It's a good use case to practice on. |
|
@jonathanudd good news. You can mix the flags however you want. You can have multiple |
src/interface_rpc_url_requirer.py
Outdated
| except KeyError: | ||
| event.defer() | ||
| return |
There was a problem hiding this comment.
What feedback from juju do you get when adding the relation if this happens?
There was a problem hiding this comment.
Not sure. Can try.
There was a problem hiding this comment.
Added some logging messages if it receives or can not receive an URL. Not sure how we can make the feedback better. I mean receiving the URL is not a guarantee that the connection actually works. Might be other stuff that makes the Parachain node not be able to use the Relaychain node. So then the question is should we make it clear for the operator that it is not able to use one of the Relaynodes in the list?
Co-authored-by: Jonathan Udd <[email protected]>
I guess we should have suspected this since the setting is |
There is now canonical/operator#1109 |
Co-authored-by: Jakob <[email protected]>
Co-authored-by: Jakob <[email protected]>
Became a bit harder for several reasons:
Found out that multiple relay nodes can be configured which will then work automatically as fallback. Example:
--relay-chain-rpc-urls ws://10.207.153.56:9933 ws://10.207.153.189:9933And of course the interface should support that.
Seems to be a bug in Juju where the relation data is not available in the departed hook. A problem since using multiple relay nodes we need to know which one to remove. I have reported this in the Matrix chat. I made a work around storing some extra info in
_stored_.