don't respond to tapped when disabled

dweymouth · Dec 24, 2023 · 20ef8cd · 20ef8cd
1 parent 95ef04e
commit 20ef8cd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/widget/slider.go b/widget/slider.go
@@ -110,6 +110,10 @@ func (s *Slider) Dragged(e *fyne.DragEvent) {
 //
 // Since: 2.4
 func (s *Slider) Tapped(e *fyne.PointEvent) {
+	if s.disabled {
+		return
+	}
+
 	driver := fyne.CurrentApp().Driver()
 	if !s.focused && !driver.Device().IsMobile() {
 		impl := s.super()

diff --git a/widget/slider_test.go b/widget/slider_test.go
@@ -320,6 +320,11 @@ func TestSlider_Disabled(t *testing.T) {
 		changes++
 	}
 
+	tap := &fyne.PointEvent{}
+	tap.Position = fyne.NewPos(30, 2)
+	slider.Tapped(tap)
+	assert.Equal(t, 0, changes)
+
 	drag := &fyne.DragEvent{}
 	drag.PointEvent.Position = fyne.NewPos(25, 2)
 	slider.Dragged(drag)