Merge pull request fyne-io#5332 from andydotxyz/fix/5331

Fix tapping of a check when its height > minHeight
dweymouth · Dec 18, 2024 · 9d5a17c · 9d5a17c
2 parents 0685580 + 9b66d57
commit 9d5a17c
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/widget/check.go b/widget/check.go
@@ -138,8 +138,11 @@ func (c *Check) Tapped(pe *fyne.PointEvent) {
 	if c.Disabled() {
 		return
 	}
+
+	minHeight := c.minSize.Height
+	minY := (c.Size().Height - minHeight) / 2
 	if !c.minSize.IsZero() &&
-		(pe.Position.X > c.minSize.Width || pe.Position.Y > c.minSize.Height) {
+		(pe.Position.X > c.minSize.Width || pe.Position.Y < minY || pe.Position.Y > minY+minHeight) {
 		// tapped outside the active area of the widget
 		return
 	}

diff --git a/widget/check_test.go b/widget/check_test.go
@@ -118,5 +118,19 @@ func TestCheck_Tapped(t *testing.T) {
 	test.Tap(check)
 	assert.False(t, check.Checked)
 	assert.False(t, check.Partial)
+}
+
+func TestCheck_Resize(t *testing.T) {
+	check := &widget.Check{Text: "test"}
+	check.Resize(fyne.NewSize(300, 200))
+	min := check.MinSize() // set up min cache
+	assert.Less(t, min.Height, check.Size().Height)
 
+	test.TapAt(check, fyne.NewPos(10, 100))
+	assert.True(t, check.Checked)
+	test.TapAt(check, fyne.NewPos(10, 100))
+	assert.False(t, check.Checked)
+
+	test.TapAt(check, fyne.NewPos(10, 10))
+	assert.False(t, check.Checked)
 }