Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tracks page supports selecting the sort order #450

Closed
wants to merge 1 commit into from

Conversation

Ericwyn
Copy link
Contributor

@Ericwyn Ericwyn commented Aug 1, 2024

support view the most recently added songs

image

support view the most recently added songs
@dweymouth
Copy link
Owner

I am undecided on this. I kind of wanted to wait for a proper Get Songs endpoint to be added to OpenSubsonic and enable the same sorting UI for this tracklist (clicking on the columns) as the other tracklists. In any case for this to be merged as-is we would need to add sort orders for Jellyfin - and it actually would be more useful there since Jellyfin actually supports sorting songs on the server-side through the API.

Maybe the thing to do for now is not create a new UI for sorting but just switch to the Recently Added order in the songs iterator? It does kind-of make more sense as a default than the artist A-Z order that is currently used.

@Ericwyn
Copy link
Contributor Author

Ericwyn commented Aug 4, 2024

I agree with you, after OpenSubsonic has an updated endpoint for getting songs, we'll standardize the display columns with the sorting of the time of addition. It's really a more friendly and correct way

But considering how fast open subsonic's api is updated (I think open subsonic's api is slow to update), it might take a bit longer?

As a self-built server, the most recent additions must be the latest favorites, so I've made this change 😁

Can I close this pr and resubmit a new one to change the default sort order in the song iterator? I can only modify Subsonic's though, I don't have Jellyfin's service to test with

@dweymouth
Copy link
Owner

Can I close this pr and resubmit a new one to change the default sort order in the song iterator? I can only modify Subsonic's though, I don't have Jellyfin's service to test with

Sounds good to me, and yeah I'll have to propose an OpenSubsonic extension at some point to get things moving on adding a tracks fetching API

@Ericwyn Ericwyn closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants