Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OpenSubsonic) Show full album dates when available #514

Merged
merged 3 commits into from
Dec 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/mediaprovider/jellyfin/jellyfinmediaprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ func fillAlbum(a *jellyfin.Album, album *mediaprovider.Album) {
album.Duration = int(a.RunTimeTicks / runTimeTicksPerSecond)
album.ArtistIDs = artistIDs
album.ArtistNames = artistNames
album.Year = a.Year
album.Date.Year = &a.Year
album.TrackCount = a.ChildCount
album.Genres = a.Genres
album.Favorite = a.UserData.IsFavorite
Expand Down
2 changes: 1 addition & 1 deletion backend/mediaprovider/mediaprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ func (f albumFilter) Matches(album *Album) bool {
if f.options.ExcludeUnfavorited && !album.Favorite {
return false
}
if y := album.Year; y < f.options.MinYear || (f.options.MaxYear > 0 && y > f.options.MaxYear) {
if y := album.YearOrZero(); y < f.options.MinYear || (f.options.MaxYear > 0 && y > f.options.MaxYear) {
return false
}
if len(f.options.Genres) == 0 {
Expand Down
17 changes: 15 additions & 2 deletions backend/mediaprovider/model.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,34 @@ const (
ReleaseTypeSpokenWord ReleaseType = 0x8000
)

type ItemDate struct {
Year *int
Month *int
Day *int
}

type Album struct {
ID string
CoverArtID string
Name string
Duration int
ArtistIDs []string
ArtistNames []string
Year int
ReissueYear int
Date ItemDate
ReissueDate ItemDate
Genres []string
TrackCount int
Favorite bool
ReleaseTypes ReleaseTypes
}

func (a *Album) YearOrZero() int {
if a.Date.Year != nil {
return *a.Date.Year
}
return 0
}

type AlbumWithTracks struct {
Album
Tracks []*Track
Expand Down
23 changes: 15 additions & 8 deletions backend/mediaprovider/subsonic/subsonicmediaprovider.go
Original file line number Diff line number Diff line change
Expand Up @@ -581,14 +581,21 @@ func fillAlbum(subAlbum *subsonic.AlbumID3, album *mediaprovider.Album) {
genres = append(genres, subAlbum.Genre)
}

album.Year = subAlbum.Year
if subAlbum.OriginalReleaseDate != nil &&
subAlbum.OriginalReleaseDate.Year != nil &&
*subAlbum.OriginalReleaseDate.Year < subAlbum.Year {
album.Year = *subAlbum.OriginalReleaseDate.Year
}
if subAlbum.ReleaseDate != nil && subAlbum.ReleaseDate.Year != nil {
album.ReissueYear = *subAlbum.ReleaseDate.Year
if ord := subAlbum.OriginalReleaseDate; ord != nil && ord.Year != nil {
album.Date = mediaprovider.ItemDate{
Year: ord.Year,
Month: ord.Month,
Day: ord.Day,
}
} else {
album.Date.Year = &subAlbum.Year
}
if rd := subAlbum.ReleaseDate; rd != nil && rd.Year != nil {
album.ReissueDate = mediaprovider.ItemDate{
Year: rd.Year,
Month: rd.Month,
Day: rd.Day,
}
}

album.ID = subAlbum.ID
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ require (
github.com/pelletier/go-toml/v2 v2.0.8
github.com/quarckster/go-mpris-server v1.0.3
github.com/supersonic-app/go-mpv v0.1.0
github.com/supersonic-app/go-subsonic v0.0.0-20241017150725-a5686988ef9c
github.com/supersonic-app/go-subsonic v0.0.0-20241224013245-9b2841f3711d
github.com/zalando/go-keyring v0.2.1
golang.org/x/net v0.25.0
golang.org/x/text v0.16.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,8 @@ github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXl
github.com/subosito/gotenv v1.2.0/go.mod h1:N0PQaV/YGNqwC0u51sEeR/aUtSLEXKX9iv69rRypqCw=
github.com/supersonic-app/go-mpv v0.1.0 h1:U+cCnLQxmpqx5mY6nMlC0J4uIdCCXUbAjpjS04XkFu8=
github.com/supersonic-app/go-mpv v0.1.0/go.mod h1:1bQz6kBQumJopXEbkiqoLxIXLy7F7yWFBvknvpAtIC0=
github.com/supersonic-app/go-subsonic v0.0.0-20241017150725-a5686988ef9c h1:UsXe5/TXViPgw21zO2Fgh0F/hSl0TXox0yjRc+vT6XQ=
github.com/supersonic-app/go-subsonic v0.0.0-20241017150725-a5686988ef9c/go.mod h1:D+OWPXeD9owcdcoXATv5YPBGWxxVvn5k98rt5B4wMc4=
github.com/supersonic-app/go-subsonic v0.0.0-20241224013245-9b2841f3711d h1:70+Nn7yh+cfeKqqXVTdpneFqXuvrBLyP7U6GVUsjTU4=
github.com/supersonic-app/go-subsonic v0.0.0-20241224013245-9b2841f3711d/go.mod h1:D+OWPXeD9owcdcoXATv5YPBGWxxVvn5k98rt5B4wMc4=
github.com/yuin/goldmark v1.1.25/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
github.com/yuin/goldmark v1.1.27/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
github.com/yuin/goldmark v1.1.32/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
Expand Down
16 changes: 14 additions & 2 deletions res/translations/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,18 @@
"Unset favorite": "Von Favoriten entfernen",
"Remove from queue": "Aus Wiedergabeliste entfernen",
"Play song radio": "Liedradio abspielen",
"to":"bis",
"by":"von"
"to": "bis",
"by": "von",
"Jan": "Jan",
"Feb": "Feb",
"Mar": "März",
"Apr": "Apr",
"May": "Mai",
"Jun": "Jun",
"Jul": "Jul",
"Aug": "Aug",
"Sept": "Sept",
"Oct": "Okt",
"Nov": "Nov",
"Dec": "Dec"
}
16 changes: 14 additions & 2 deletions res/translations/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,18 @@
"Unset favorite": "Unset favorite",
"Remove from queue": "Remove from queue",
"Play song radio": "Play song radio",
"to":"to",
"by":"by"
"to": "to",
"by": "by",
"Jan": "Jan",
"Feb": "Feb",
"Mar": "Mar",
"Apr": "Apr",
"May": "May",
"Jun": "Jun",
"Jul": "Jul",
"Aug": "Aug",
"Sept": "Sept",
"Oct": "Oct",
"Nov": "Nov",
"Dec": "Dec"
}
14 changes: 13 additions & 1 deletion res/translations/es.json
Original file line number Diff line number Diff line change
Expand Up @@ -229,5 +229,17 @@
"Remove from queue": "Remover de la cola",
"Play song radio": "Reproducir canciones similares",
"to": "a",
"by": "por"
"by": "por",
"Jan": "Ene",
"Feb": "Feb",
"Mar": "Mar",
"Apr": "Abr",
"May": "May",
"Jun": "Jun",
"Jul": "Jul",
"Aug": "Ago",
"Sept": "Set",
"Oct": "Oct",
"Nov": "Nov",
"Dec": "Dic"
}
14 changes: 13 additions & 1 deletion res/translations/fr.json
Original file line number Diff line number Diff line change
Expand Up @@ -228,5 +228,17 @@
"Remove from queue": "Retirer de la file d'attente",
"Play song radio": "Lire une radio basée sur la piste",
"to": "à",
"by": "par"
"by": "par",
"Jan": "Janv",
"Feb": "Févr",
"Mar": "Mars",
"Apr": "Avr",
"May": "Mai",
"Jun": "Juin",
"Jul": "Juil",
"Aug": "Août",
"Sept": "Sept",
"Oct": "Oct",
"Nov": "Nov",
"Dec": "Déc"
}
14 changes: 13 additions & 1 deletion res/translations/it.json
Original file line number Diff line number Diff line change
Expand Up @@ -226,5 +226,17 @@
"Remove from queue": "Rimuovi dalla coda",
"Play song radio": "Avvia radio mix",
"to": "al",
"by": "by"
"by": "by",
"Jan": "Gen",
"Feb": "Feb",
"Mar": "Mar",
"Apr": "Apr",
"May": "Mag",
"Jun": "Giu",
"Jul": "Lug",
"Aug": "Ago",
"Sept": "Set",
"Oct": "Ott",
"Nov": "Nov",
"Dec": "Dic"
}
14 changes: 13 additions & 1 deletion res/translations/ro.json
Original file line number Diff line number Diff line change
Expand Up @@ -218,5 +218,17 @@
"Remove from queue": "Șterge din lista de redare",
"Play song radio": "Redă melodie radio",
"to": "la",
"by": "de"
"by": "de",
"Jan": "Ian",
"Feb": "Feb",
"Mar": "Mar",
"Apr": "Apr",
"May": "Mai",
"Jun": "Iunie",
"Jul": "Iulie",
"Aug": "Aug",
"Sept": "Sept",
"Oct": "Oct",
"Nov": "Noiem",
"Dec": "Dec"
}
7 changes: 3 additions & 4 deletions ui/browsing/albumpage.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package browsing
import (
"fmt"
"log"
"strconv"

"github.com/dweymouth/supersonic/backend"
"github.com/dweymouth/supersonic/backend/mediaprovider"
Expand Down Expand Up @@ -370,9 +369,9 @@ func formatMiscLabelStr(a *mediaprovider.AlbumWithTracks) string {
if a.TrackCount == 1 {
tracks = lang.L("track")
}
yearStr := strconv.Itoa(a.Year)
if a.ReissueYear > a.Year {
yearStr += fmt.Sprintf(" (%s %d)", lang.L("reissued"), a.ReissueYear)
yearStr := util.FormatItemDate(a.Date)
if y := a.ReissueDate.Year; y != nil && *y > a.YearOrZero() {
yearStr += fmt.Sprintf(" (%s %d)", lang.L("reissued"), util.FormatItemDate(a.ReissueDate))
}
return fmt.Sprintf("%s · %d %s · %s%s", yearStr, a.TrackCount, tracks, discs, util.SecondsToTimeString(float64(a.Duration)))
}
Expand Down
6 changes: 3 additions & 3 deletions ui/browsing/artistpage.go
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,12 @@ func (a *ArtistPage) getGridViewAlbumsModel() []widgets.GridViewItemModel {
return nil
}
sortFunc := func(x, y int) bool {
return a.artistInfo.Albums[x].Year < a.artistInfo.Albums[y].Year
return a.artistInfo.Albums[x].YearOrZero() < a.artistInfo.Albums[y].YearOrZero()
}
switch a.cfg.DiscographySort {
case discographySorts[1]: /*year descending*/
sortFunc = func(x, y int) bool {
return a.artistInfo.Albums[x].Year > a.artistInfo.Albums[y].Year
return a.artistInfo.Albums[x].YearOrZero() > a.artistInfo.Albums[y].YearOrZero()
}
case discographySorts[2]: /*name*/
sortFunc = func(x, y int) bool {
Expand All @@ -222,7 +222,7 @@ func (a *ArtistPage) getGridViewAlbumsModel() []widgets.GridViewItemModel {
Name: al.Name,
ID: al.ID,
CoverArtID: al.CoverArtID,
Secondary: []string{strconv.Itoa(al.Year)},
Secondary: []string{strconv.Itoa(al.YearOrZero())},
}
})
}
Expand Down
69 changes: 69 additions & 0 deletions ui/util/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,75 @@ import (
"golang.org/x/net/html"
)

type DateFormat int

const (
DateFormatDMY DateFormat = iota
DateFormatMDY
DateFormatYMD
)

func dateFormatForLocale(locale string) DateFormat {
var region string
if i := strings.Index(locale, "-"); i > 0 && len(locale) >= 5 {
region = locale[i+1 : i+3]
}
switch strings.ToUpper(region) {
case "US":
return DateFormatMDY
case "CN", "JP", "KR", "HU", "MN", "LT":
return DateFormatYMD
default:
return DateFormatDMY
}
}

func shortMonthName(month int) string {
var months = [12]string{"Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sept", "Oct", "Nov", "Dec"}
if month >= 1 && month <= 12 {
return lang.L(months[month-1])
}
return ""
}

func FormatItemDate(date mediaprovider.ItemDate) string {
var sb strings.Builder
df := dateFormatForLocale(fyne.CurrentDevice().Locale().String())
switch df {
case DateFormatDMY:
if d := date.Day; d != nil {
sb.WriteString(fmt.Sprintf("%d ", *d))
}
if m := date.Month; m != nil {
sb.WriteString(shortMonthName(*m) + " ")
}
if y := date.Year; y != nil {
sb.WriteString(fmt.Sprintf("%d", *y))
}
case DateFormatMDY:
if m := date.Month; m != nil {
sb.WriteString(shortMonthName(*m) + " ")
}
if d := date.Day; d != nil {
sb.WriteString(fmt.Sprintf("%d, ", *d))
}
if y := date.Year; y != nil {
sb.WriteString(fmt.Sprintf("%d", *y))
}
case DateFormatYMD:
if y := date.Year; y != nil {
sb.WriteString(fmt.Sprintf("%d ", *y))
}
if m := date.Month; m != nil {
sb.WriteString(shortMonthName(*m) + " ")
}
if d := date.Day; d != nil {
sb.WriteString(fmt.Sprintf("%d", *d))
}
}
return sb.String()
}

var BoldRichTextStyle = widget.RichTextStyle{TextStyle: fyne.TextStyle{Bold: true}, Inline: true}

func MakeOpaque(c color.Color) color.Color {
Expand Down
4 changes: 2 additions & 2 deletions ui/widgets/gridview.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ func (g gridViewAlbumIterator) NextN(n int) []GridViewItemModel {
Secondary: al.ArtistNames,
SecondaryIDs: al.ArtistIDs,
}
if al.Year > 0 {
model.Suffix = strconv.Itoa(al.Year)
if y := al.Date.Year; y != nil {
model.Suffix = strconv.Itoa(*al.Date.Year)
}
return model
})
Expand Down
Loading