Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validations not enabled by default #204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lawso017
Copy link
Collaborator

@p8 Here is a PR that changes the validations so they are all disabled by default.

I think I hit all the Readme docs as well to note that validations are optional but can be enabled either globally (via the config file) or in individual models when mounting the uploader.

Again, my argument for this is that version 0.0.15 did not have validations. So code running & tested under that version should not break due to the presence of new default validations during an upgrade. But wanted your take on it as well so I've done it on my branch first.

@p8
Copy link
Collaborator

p8 commented Jun 12, 2016

@lawso017 Sorry for the confusion, but 0.0.15 did have validations (https://github.com/dwilkie/carrierwave_direct/blob/v0.0.15/lib/carrierwave_direct/validations/active_model.rb). Things probably broke because of the multi column implementation. I agree we might want to turn off default validations but this might break backwards compatibility for those who expect the validations to be turned on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants