-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More css vars - take 2 #44
Conversation
Really nice and really nice documentation as well. |
@all-contributors please add @mmkal for docs, code, review |
This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 660 |
@pvspain any objections to me merging this in? |
@mmkal would you mind updating from |
Yes, will do later tonight (EST time(!)). I want to merge from main anyway, now that #45 is in, so the diff is easier to grok. |
@dwmkerr done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mmkal. This looks great - thanks!
There's four things I'd like you to have a look at, regarding a couple of clobbered values and documentation. (We need a section on documentation!) They are all commented below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This look good @mmkal.
A comment in there to leave a reference to styling in the README. That should have been there already - my bad.
@all-contributors please add @mmkal for code, docs, review |
I've put up a pull request to add @mmkal! 🎉 |
Second attempt at #41
This doesn't go as far as dropping LESS completely (per @pvspain's comment), but it does reduce the dependency by switching over more LESS variables to CSS variables.
The rationale (summing up from the other PR): it makes customising styling easier for developers using this library - CSS variables can be set in userland CSS files which override defaults in crosswords-js, and they will be applied consistently everywhere (for example, changing the cell "highlight" colour and making sure it's in sync across clues, the grid and any other elements users might add; or adding a new screen-width breakpoint with a bigger or smaller cell size).
I've added some docs under
### Styling
in the root readme. They could be more exhaustive but they will point developers using this library in the right direction, and I want to avoid docs churn.Rationale for not ditching LESS right now:
I also ran the
build
script since thedist/
folder was out of date again. I might open a separate PR that does only that to merge in first, though, since then it'd be easier to see what the net effect of this PR is (including the fact that it net removes code despite adding functionality).