Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: instruct @dependabot to ignore httpoison and jason updates for #45 #46

Merged
merged 7 commits into from
Jan 31, 2024
Merged

PR: instruct @dependabot to ignore httpoison and jason updates for #45 #46

merged 7 commits into from
Jan 31, 2024

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jan 31, 2024 •
edited
Loading

  • avoid auto-upgrading httpoison or jason (@dependabot) 👌
  • downgrade httpoison and jason to maximise compatibility. 🧑‍💻 ⏳

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies elixir Pull requests that update Elixir code user-feedback Feedback from people using the App labels Jan 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (827a908) 100.00% compared to head (b74360f) 100.00%.

❗ Current head b74360f differs from pull request most recent head 75ae7ea. Consider uploading reports for the commit 75ae7ea to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           34        34           
=========================================
  Hits            34        34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Jan 31, 2024
@nelsonic nelsonic requested a review from asntc January 31, 2024 14:50
asntc
asntc approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@asntc asntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@asntc asntc merged commit c380e75 into main Jan 31, 2024
1 check passed
@asntc asntc deleted the freeze-httpoison-jason-issue-#45 branch January 31, 2024 14:51
@nelsonic nelsonic mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asntc asntc asntc approved these changes

Assignees
No one assigned
Labels
awaiting-review An issue or pull request that needs to be reviewed elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @asntc