[PR] Fix CI API tests failing #314

LuchoTurtle · 2023-02-21T15:28:46Z

closes #297
closes #315

codecov · 2023-02-21T15:34:40Z

Codecov Report

Merging #314 (999ee62) into main (cd0b132) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #314   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          475       475           
=========================================
  Hits           475       475

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

LuchoTurtle · 2023-02-21T16:05:21Z

This is super weird. The server is running and I've tested the tests locally and they all pass. But it seems that the tests are not reaching the server running on localhost. 🤔

LuchoTurtle · 2023-02-21T17:35:31Z

I've looked everywhere but none of the issues help the case. The connection to localhost seems to be not be reachable:

Again, running these tests on my computer works. And I'm running mix phx.server and running the tests against the live running server. However this seems to not be the case within github actions (for some reason, it has stopped establishing a connection on the server running within the service of the action pipeline).

#297

…297

nelsonic · 2023-02-27T14:18:56Z

@LuchoTurtle this is looking promising. 👌
Assign when ready, then take a look at upgrading the project: #322 🙏

…iles#r1119365779

nelsonic · 2023-02-27T22:23:09Z

lib/api/fly_dev.json

@@ -0,0 +1,12 @@
+{
+  "host": "https://mvp-pr-314.fly.dev",


does this hard-coding of the host mean that this will only work while the 314 PR is open? 💭
What happens to the next PR that doesn't have this ID?

@nelsonic dang it, I thought I had gotten everything covered. I knew one last step was missing. You are right, this was a temporary fix just to see if the runs were being correctly executed on my local machine back-to-back.

Please assign the PR back to me, I will address this. Sorry about this, completely forgot this last step.

Sure thing. re-assigned to you. Please review your own PRs before assigning them to ensure you have checked everything. 🙏

…yl/mvp/pull/314/files#r1119365779

nelsonic · 2023-02-28T10:01:42Z

@LuchoTurtle do you think we could remove the line:

mvp/.github/workflows/pr.yml

Line 73 in f96d854

needs: [build]

So that the deployment of the review_app is not dependent (Waiting for) the build ... 💭
Is there an reason that these two jobs need to be run in series?
Could they be run in parallel so that we aren't waiting?

If the build & test fails we just focus on that.
But I feel like waiting for both jobs to run in series while we're debugging this is mega tedious.

I feel like we're burning a lot of time waiting for the CI to run to debug this ... ⏳
Reminds me of:

LuchoTurtle · 2023-02-28T10:06:33Z

The json file seems to already be switching properly.
But for some odd reason, the first test fails

Run hopp test -e ./lib/api/fly_dev.json ./lib/api/MVP.json

Running: MVP/Tags/Create tag
 POST  https://mvp-pr-31[4](https://github.com/dwyl/mvp/actions/runs/4291630310/jobs/7477259821#step:5:5).fly.dev/api/tags ERROR
⚠ Error running request.
⚠ Error running test-script.

While the other ones all succeed. This didn't happen prior to changing the json file, which doesn't make sense. The error is not shown either and I can't reproduce this on my localhost :/

… build step. #297

nelsonic · 2023-02-28T10:16:48Z

OK. looks like you've figured out the "hard" part of injecting the review app URL into the .json file ... 🎉
there doesn't appear to be a way of running hopp with a "verbose" flag/option ... https://docs.hoppscotch.io/cli 🤷‍♂️

LuchoTurtle · 2023-02-28T10:18:58Z

That appears to have fixed it.
Going to change the build-review-apps.md file before submitting for review.

LuchoTurtle · 2023-02-28T10:23:19Z

Nevermind. I don't know why Github is showing it was unsuccessful when the https://github.com/dwyl/mvp/actions/runs/4291836918 run was ...

LuchoTurtle · 2023-02-28T10:29:45Z

Ok, that should do it. Over to you, @nelsonic

nelsonic

@LuchoTurtle looks good. 👌
Really hope this is more robust now. 🤞🏼
Thanks. ☀️

fix: Trying to fix CI API tests failing. #297

7c92688

LuchoTurtle added in-progress An issue or pull request that is being worked on by the assigned person chore a tedious but necessary task often paying technical debt labels Feb 21, 2023

LuchoTurtle self-assigned this Feb 21, 2023

LuchoTurtle added the bug Suspected or confirmed bug (defect) in the code label Feb 21, 2023

fix: Sleeping for longer to see if it's enough time to start API tests.

0e3aa36

#297

LuchoTurtle added 12 commits February 21, 2023 17:57

fix: Changing hopps CLI version. #297

7c622c9

fix: Checking if CI makes outbound calls. #297

8b5e4c3

fix: Switching order. Deploying app first and testing later. #297

69cdac1

fix: Fix yaml syntax. #297

a1ea903

fix: Fixing CI yaml syntax. #297

77d357f

fix: Syntax error. #297

67be013

fix: Fix yamlf ile. #297

ee1457d

fix: Refactoring workflows. #297

3ea81f6

fix: Renaming branch_ci to PR_ci. #297

2bf5614

fix: Checking out on PR_ci.yml file. #297

ed4f8c3

fix: Using post-request scripts to set env variables for tests running.

d7fba55

#297

feat: Adding comments and removing seeds. #297

8a584c8

This was referenced Feb 24, 2023

build(deps): Bump phoenix_live_view from 0.18.15 to 0.18.16 #317

Merged

build(deps): Bump petal_components from 1.0.0 to 1.0.3 #321

Merged

fix: Making tests run regardless of seeds. Adding new env variables. #…

1548b7f

…297

LuchoTurtle added 2 commits February 27, 2023 15:26

fix: Updating README. #297

2007d8c

fix: Fixing typos in review app document. #297

1d9c49a

LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Feb 27, 2023

LuchoTurtle removed their assignment Feb 27, 2023

revert name main_ci.yml ci.yml https://github.com/dwyl/mvp/pull/314/f…

7447bfc

…iles#r1119365779

nelsonic reviewed Feb 27, 2023

View reviewed changes

rename PR_ci.yml to just pr.yml for consistency https://github.com/dw…

1a7752c

…yl/mvp/pull/314/files#r1119365779

nelsonic added in-progress An issue or pull request that is being worked on by the assigned person and removed in-review Issue or pull request that is currently being reviewed by the assigned person labels Feb 27, 2023

nelsonic assigned LuchoTurtle and unassigned nelsonic Feb 27, 2023

LuchoTurtle added 8 commits February 28, 2023 09:07

fix: Changing JSON file to deployed app dynamically. #297

82368a2

fix: Fixing warnings in yaml file. #297

8b5cb57

fix: Fixing join operation on yaml file. #297

b8fca4b

fix: Fixing join function in workflow. #297

1d65ecd

fix: Fixing JSON var changing. #297

c8ab185

fix: Trying to change json file. #297

7bf1fad

fix: Placing the json field changing to api_definition job. #297

077c2a9

feat: Adding missing values to fly_dev.json file. #297

f96d854

fix: Re-exporting MVP test suite changes. Review_app not dependant on…

476fccb

… build step. #297

fix: Fixing the build-review-apps.md with latest changes/ #297

999ee62

LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Feb 28, 2023

LuchoTurtle assigned nelsonic and unassigned LuchoTurtle Feb 28, 2023

nelsonic approved these changes Feb 28, 2023

View reviewed changes

nelsonic merged commit a30aa78 into main Feb 28, 2023

nelsonic deleted the fix-CI-#297 branch February 28, 2023 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PR] Fix CI API tests failing #314

[PR] Fix CI API tests failing #314

LuchoTurtle commented Feb 21, 2023 •

edited

Loading

codecov bot commented Feb 21, 2023 •

edited

Loading

LuchoTurtle commented Feb 21, 2023

LuchoTurtle commented Feb 21, 2023

nelsonic commented Feb 27, 2023

nelsonic Feb 27, 2023

LuchoTurtle Feb 27, 2023 •

edited

Loading

nelsonic Feb 27, 2023

nelsonic commented Feb 28, 2023

LuchoTurtle commented Feb 28, 2023

nelsonic commented Feb 28, 2023

LuchoTurtle commented Feb 28, 2023

LuchoTurtle commented Feb 28, 2023

LuchoTurtle commented Feb 28, 2023

nelsonic left a comment

[PR] Fix CI API tests failing #314

[PR] Fix CI API tests failing #314

Conversation

LuchoTurtle commented Feb 21, 2023 • edited Loading

codecov bot commented Feb 21, 2023 • edited Loading

Codecov Report

LuchoTurtle commented Feb 21, 2023

LuchoTurtle commented Feb 21, 2023

nelsonic commented Feb 27, 2023

nelsonic Feb 27, 2023

Choose a reason for hiding this comment

LuchoTurtle Feb 27, 2023 • edited Loading

Choose a reason for hiding this comment

nelsonic Feb 27, 2023

Choose a reason for hiding this comment

nelsonic commented Feb 28, 2023

LuchoTurtle commented Feb 28, 2023

nelsonic commented Feb 28, 2023

LuchoTurtle commented Feb 28, 2023

LuchoTurtle commented Feb 28, 2023

LuchoTurtle commented Feb 28, 2023

nelsonic left a comment

Choose a reason for hiding this comment

LuchoTurtle commented Feb 21, 2023 •

edited

Loading

codecov bot commented Feb 21, 2023 •

edited

Loading

LuchoTurtle Feb 27, 2023 •

edited

Loading