Ecto changeset associations #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update association to use Ecto.Changeset functions - Make sure seeds file can creates statuses and person related to: #94
SimonLab
added
the
in-progress
SimonLab
changed the base branch from
main
to
phoenix-1.6-2022-refresh-issue-#89
Update the item status using put_assoc
Update the list_item function to checkt the status ecto assocation value is not "deleted" ref: #94 (comment)
Update test for #94
SimonLab
added
awaiting-review
nelsonic
approved these changes
Jul 13, 2022
nelsonic
reviewed
Jul 14, 2022
| field :text, :string | ||
|
|
||
| belongs_to :status, App.Status, on_replace: :nilify |
There was a problem hiding this comment.
From a beginner's perspective, it doesn't make any sense that an item would "belongs_to" a Status.
An item can have a status but it doesn't "belong" to the status.
This is immediately confusing and adds no value to the MVP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge after #97
ref: #94