Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Expand Tutorial Instructions #42 #46

Merged
merged 15 commits into from
Jun 20, 2022
Merged

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jun 8, 2022

This PR builds upon @SimonLab's superb work expanding and some cases trimming the instructions. #42
Also adds some UI Stylin' using Tailwind CSS for practice #4

Before:
image

After:
liveview-chat-with-tailwind-css

Thanks! 🌻

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person labels Jun 8, 2022
@nelsonic nelsonic self-assigned this Jun 8, 2022
@nelsonic nelsonic had a problem deploying to liveview-chat-example June 8, 2022 06:23 Failure
@nelsonic nelsonic had a problem deploying to liveview-chat-example June 10, 2022 08:50 Failure
@nelsonic nelsonic added the priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished label Jun 11, 2022
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 11, 2022 05:30 Inactive
@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #46 (f7d8de0) into main (47eb096) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines           48        53    +5     
=========================================
+ Hits            48        53    +5     
Impacted Files Coverage Δ
...b/liveview_chat_web/controllers/auth_controller.ex 100.00% <100.00%> (ø)
lib/liveview_chat_web/live/message_live.ex 100.00% <100.00%> (ø)
lib/liveview_chat_web/router.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4857be7...f7d8de0. Read the comment docs.

@nelsonic
Copy link
Member Author

This is taking longer than I had hoped ... ⏳
Each time I sit down to try and work on this I am distracted by someone/something ... 🙃
This morning it was: iteles/blw-baby#32 which I felt deserved my attention. 💭

Taking my laptop with me to the wedding this weekend.
if there is a quiet period in the morning when everyone else is "recovering" and A+++ is still sleeping ...
I will try and continue making progress on it. 🤞

@nelsonic nelsonic temporarily deployed to liveview-chat-example June 16, 2022 07:34 Inactive
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 16, 2022 15:09 Inactive
@nelsonic nelsonic changed the title WiP PR: Expand Tutorial Instructions #42 PR: Expand Tutorial Instructions #42 Jun 16, 2022
@nelsonic nelsonic mentioned this pull request Jun 16, 2022
1 task
@nelsonic nelsonic had a problem deploying to liveview-chat-example June 16, 2022 16:47 Failure
@nelsonic
Copy link
Member Author

Ah, I accidentally removed the presence "2 guests" display. Will add it back and then assign the PR for review. 🤦‍♂️ 🧑‍💻 ⏳

@nelsonic nelsonic temporarily deployed to liveview-chat-example June 16, 2022 21:08 Inactive
@nelsonic
Copy link
Member Author

Re-added the Presence, but in the Nav:
image

Not going to spend any more time on this. I think the tutorial is where it needs to be. ✅
We can move on to building our App!! 💭

@nelsonic
Copy link
Member Author

@SimonLab Apologies for this being a bit longer than I would have hoped. 🙃
Not urgent to review. But when you can. Thanks. 🙏

@nelsonic nelsonic removed their assignment Jun 16, 2022
@nelsonic nelsonic mentioned this pull request Jun 16, 2022
7 tasks
@nelsonic
Copy link
Member Author

Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've spotted a few typos to fix.
I've also noticed the login button is still displayed when the user is authenticated (on the name, message section)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Jun 17, 2022
@SimonLab SimonLab added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Jun 17, 2022
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 17, 2022 09:04 Inactive
@nelsonic nelsonic assigned SimonLab and unassigned nelsonic Jun 18, 2022
@nelsonic nelsonic had a problem deploying to liveview-chat-example June 18, 2022 11:01 Failure
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 18, 2022 11:19 Inactive
@nelsonic nelsonic temporarily deployed to liveview-chat-example June 18, 2022 11:37 Inactive
@nelsonic
Copy link
Member Author

@SimonLab please take another look when you're back at your desk on Monday. Thanks! ☀️

Copy link
Member

@SimonLab SimonLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the updates 👍

@SimonLab SimonLab merged commit f0d1e3e into main Jun 20, 2022
@SimonLab SimonLab deleted the expand-instructions-issue-#42 branch June 20, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing functionality in-review Issue or pull request that is currently being reviewed by the assigned person priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants