-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Expand Tutorial Instructions #42 #46
Conversation
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 6 +1
Lines 48 53 +5
=========================================
+ Hits 48 53 +5
Continue to review full report at Codecov.
|
This is taking longer than I had hoped ... ⏳ Taking my laptop with me to the wedding this weekend. |
Ah, I accidentally removed the presence "2 guests" display. Will add it back and then assign the PR for review. 🤦♂️ 🧑💻 ⏳ |
@SimonLab Apologies for this being a bit longer than I would have hoped. 🙃 |
Link to read the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've spotted a few typos to fix.
I've also noticed the login button is still displayed when the user is authenticated (on the name, message section)
Co-authored-by: Simon <[email protected]>
…ix-liveview-chat-example into expand-instructions-issue-#42
@SimonLab please take another look when you're back at your desk on Monday. Thanks! ☀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the updates 👍
This PR builds upon @SimonLab's superb work expanding and some cases trimming the instructions. #42
Also adds some UI Stylin' using
Tailwind
CSS for practice #4Before:
After:
Thanks! 🌻