Honor waitTime for Deploy commands

[brandonmikeska]

Summary generated by Reviewpad on 24 Nov 23 18:59 UTC

This pull request includes several patches:

1. Patch 1/4 fixes an issue with multiple workItem filters by spreading out the filters before pushing them. This patch affects the ReleaseImpl.ts file in the packages/sfpowerscripts-cli/src/impl/release directory.

2. Patch 2/4 applies a codefactor suggestion by fixing an issue in the ReleaseImpl.ts file. It changes workitemFilters to releaseDefinition?.changelog?.workItemFilters.

3. Patch 3/4 also fixes an issue in the ReleaseImpl.ts file. It adds an additional check to only push workItemFilters if they exist in releaseDefinition.changelog.

4. Patch 4/4 modifies the DeploySourceToOrgImpl.ts file in the packages/core/src/deployers directory. It changes the deployment result timeout to honor the user's input for the wait time instead of hardcoding it.

Please review these patches and provide any necessary feedback.

Checklist

All items have to be completed before a PR is merged

• Adhere to Contribution Guidelines
• Updates to Decision Records considered?
• Updates to documentation at DX@Scale Guide considered?
• Tested changes?
• Unit Tests new and existing passing locally?

[reviewpad]

Reviewpad Report

‼️ Errors

• Unconventional commit detected: 'Fix multiple workItem filters

spread out the filters before pushing' (801656d)

• Unconventional commit detected: 'Merge branch 'main' into main' (3f0d89f)
• Unconventional commit detected: 'Merge branch 'main' into main' (a267459)
• Unconventional commit detected: 'Honor deploy command waitTime

Instead of hardcoding the deployment result timeout - honor the user's input.' (23d9784)

• Unconventional commit detected: 'Merge branch 'dxatscale:main' into main' (993a069)
• Unconventional title detected: 'Honor waitTime for Deploy commands' illegal 'H' character in commit message type: col=00

⚠️ Warnings

• Please link an issue to the pull request

[brandonmikeska]

@azlam-abdulsalam this should fix #1440

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bac4fa3) 46.83% compared to head (993a069) 46.83%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1443   +/-   ##
=======================================
  Coverage   46.83%   46.83%           
=======================================
  Files          70       70           
  Lines        2667     2667           
  Branches      300      300           
=======================================
  Hits         1249     1249           
  Misses       1416     1416           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[azlam-abdulsalam]

Thanks @brandonmikeska , looking good!