Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

feat(releaseconfig): add an option for explict dependency for packages within the repository #1447

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

azlam-abdulsalam
Copy link
Contributor

@azlam-abdulsalam azlam-abdulsalam commented Dec 12, 2023

Adds an option in release config for explict dependency, especially allowing for validate to ensure
dependencies of a package (source/data) within the same repository , though excluded are allowed to
be installed

Summary generated by Reviewpad on 12 Dec 23 13:05 UTC

This pull request adds an option in the release config for explicit dependencies, allowing for validation of dependencies within the same repository. It includes changes to the CLI command, schema file, and implementation files related to release configurations. Specifically, it adds a new flag "explictDependencyCheck" to activate the dependency check and handle impact accordingly.

Checklist

All items have to be completed before a PR is merged

  • Adhere to Contribution Guidelines
  • Updates to Decision Records considered?
  • Updates to documentation at DX@Scale Guide considered?
  • Tested changes?
  • Unit Tests new and existing passing locally?

…s within the repository

Adds an option in release config for explict dependency, especially allowing for validate to ensure
dependencies of a  package (source/data) within the same repository , though excluded are allowed to
be installed
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Dec 12, 2023
Copy link

reviewpad bot commented Dec 12, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa740e2) 46.83% compared to head (13865be) 46.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1447   +/-   ##
=======================================
  Coverage   46.83%   46.83%           
=======================================
  Files          70       70           
  Lines        2667     2667           
  Branches      300      309    +9     
=======================================
  Hits         1249     1249           
+ Misses       1416     1389   -27     
- Partials        2       29   +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@crazynammer crazynammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@reviewpad reviewpad bot requested a review from ethan-sargent December 12, 2023 22:18
@azlam-abdulsalam azlam-abdulsalam merged commit 4d0159a into main Dec 12, 2023
6 of 7 checks passed
@azlam-abdulsalam azlam-abdulsalam deleted the feat/explictDependency branch December 12, 2023 22:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants