Update logic for coloring chapters' last action #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from Michelle Tested by manually setting last event dates to be 29,30,58,59 days ago in local database and checking the color.
jakehobbs
approved these changes
Jun 1, 2024
| @@ -871,10 +871,10 @@ export default Vue.extend({ | |||
| if (time.isValid()) { | |||
| c = 'is-danger'; | |||
| } | |||
| if (time.isAfter(dayjs().add(-2, 'month'))) { | |||
| if (time.isAfter(dayjs().add(-58, 'day'))) { | |||
There was a problem hiding this comment.
yuck forgot we were still using dayjs in this 🤣
fine thought for now obvs
There was a problem hiding this comment.
lol. noted dayjs is yuck.
There was a problem hiding this comment.
not as bad as moment. i didn't realize it's still being updated, but it is. i prefer date-fns these days though, and it has a smaller bundle size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.